Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert PSP migration to PSA #5605

Merged
merged 1 commit into from
Oct 5, 2022
Merged

Revert PSP migration to PSA #5605

merged 1 commit into from
Oct 5, 2022

Conversation

JeromeJu
Copy link
Member

@JeromeJu JeromeJu commented Oct 5, 2022 •
edited
Loading

Changes

This commit reverts the PSP migration as it blocks v0.41. The follow-up
configurations for PodSecurity will be added.

Part of #5603
/kind bug

cc @abayer @lbernick

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • [n/a] Has Docs included if any changes are user facing
  • [n/a] Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • [n/a] Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • [n/a] Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

afrittoli
afrittoli reviewed Oct 5, 2022
View reviewed changes
Copy link
Member

@afrittoli afrittoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@abayer
Copy link
Contributor

abayer commented Oct 5, 2022

/approve

@afrittoli
Copy link
Member

@abayer we definitely need testing against multiple k8s versions - at least at nightly

@abayer abayer mentioned this pull request Oct 5, 2022
Closed
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abayer, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 5, 2022
@tekton-robot tekton-robot added lgtm Indicates that a PR is ready to be merged. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. kind/bug Categorizes issue or PR as related to a bug. labels Oct 5, 2022
@JeromeJu
Copy link
Member Author

JeromeJu commented Oct 5, 2022

/test check-pr-has-kind-label

@JeromeJu
Copy link
Member Author

JeromeJu commented Oct 5, 2022

/release-note-none

@tekton-robot
Copy link
Collaborator

@JeromeJu: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-tekton-pipeline-alpha-integration-tests
  • /test pull-tekton-pipeline-build-tests
  • /test pull-tekton-pipeline-integration-tests
  • /test tekton-pipeline-unit-tests

The following commands are available to trigger optional jobs:

  • /test pull-tekton-pipeline-go-coverage

Use /test all to run all jobs.

In response to this:

/test check-pr-has-kind-label

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Oct 5, 2022
@afrittoli
Copy link
Member

/restest

@dibyom
Copy link
Member

dibyom commented Oct 5, 2022

Looks like Prow is stuck on WAIT. Let me try to close and re-open

@dibyom dibyom closed this Oct 5, 2022
@dibyom dibyom reopened this Oct 5, 2022
@tekton-robot tekton-robot merged commit 5a0bd42 into tektoncd:main Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afrittoli afrittoli afrittoli left review comments

@dibyom dibyom Awaiting requested review from dibyom

@vdemeester vdemeester Awaiting requested review from vdemeester

Assignees

@afrittoli afrittoli

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@JeromeJu @abayer @afrittoli @tekton-robot @dibyom @vdemeester