Use kmap.Union to merge two maps #5660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
kind/cleanup
tekton-robot
added
release-note-none
|
Thanks @dibyom for the suggestion. |
|
The following is the coverage report on the affected files.
|
Previously, we use self-defined helper function to merge two maps. Now, we use the existing [kmap.Union](https://pkg.go.dev/knative.dev/pkg@v0.0.0-20221014164553-b812affa3893/kmap#Union) method to achieve this functionality. Signed-off-by: Chuang Wang <chuangw@google.com>
|
The following is the coverage report on the affected files.
|
vdemeester
approved these changes
Oct 19, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
/retest |
chuangw6
added a commit
to chuangw6/pipeline
that referenced
this pull request
Oct 19, 2022
Add on to tektoncd#5660. Previously, we use too much self-invented code to merge two maps. Now we use the existing [kmap.Union](https://pkg.go.dev/knative.dev/pkg@v0.0.0-20221014164553-b812affa3893/kmap#Union) to merge maps. Signed-off-by: Chuang Wang <chuangw@google.com>
7 tasks
chuangw6
added a commit
to chuangw6/pipeline
that referenced
this pull request
Oct 19, 2022
Add on to tektoncd#5660. Previously, we use too much self-invented code to merge two maps. Now we use the existing [kmap.Union](https://pkg.go.dev/knative.dev/pkg@v0.0.0-20221014164553-b812affa3893/kmap#Union) to merge maps. Signed-off-by: Chuang Wang <chuangw@google.com>
tekton-robot
pushed a commit
that referenced
this pull request
Oct 19, 2022
Add on to #5660. Previously, we use too much self-invented code to merge two maps. Now we use the existing [kmap.Union](https://pkg.go.dev/knative.dev/pkg@v0.0.0-20221014164553-b812affa3893/kmap#Union) to merge maps. Signed-off-by: Chuang Wang <chuangw@google.com>
JeromeJu
pushed a commit
to JeromeJu/pipeline
that referenced
this pull request
Oct 24, 2022
Add on to tektoncd#5660. Previously, we use too much self-invented code to merge two maps. Now we use the existing [kmap.Union](https://pkg.go.dev/knative.dev/pkg@v0.0.0-20221014164553-b812affa3893/kmap#Union) to merge maps. Signed-off-by: Chuang Wang <chuangw@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
/kind cleanup
Previously, we use self-defined helper function to merge two maps.
Now, we use the existing kmap.Union method to achieve this functionality.
Signed-off-by: Chuang Wang chuangw@google.com
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes