[TEP074] Remove Image pipelineResources #6002

JeromeJu · 2023-01-17T23:35:22Z

Changes

This commit removes the Image Resources support.

This PR removes github.com/tektoncd/pipeline/pkg/apis/resource/v1alpha1/image
the imagedigestexporter and the docs for image resources.It also removes the
integration tests helm_task_test andhermetic_taskrun_test as these tests
are testing building against image resources.

Removal of pipelineResources, as in #5967 has been broken up into removal of each resources according to small PRs.

Part of #5967
/kind misc

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

Has Docs included if any changes are user facing
Has Tests included if any functionality added or changed
Follows the commit message standard
Meets the Tekton contributor standards (including
functionality, content, code)
Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

action required: please migrate off of `image` `pipelineresources` as it is removed, please refer to the doc at https://github.com/tektoncd/pipeline/blob/main/docs/pipelineresources.md#replacing-an-image-resource
`imagedigestexporter` image will not be built nor maintained from now on

tekton-robot · 2023-01-17T23:40:06Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go	94.9%	94.7%	-0.3
pkg/reconciler/taskrun/resources/output_resource.go	89.1%	87.0%	-2.2
pkg/reconciler/taskrun/taskrun.go	83.6%	83.9%	0.3
pkg/reconciler/taskrun/validate_resources.go	98.5%	98.1%	-0.4

tekton-robot · 2023-01-17T23:42:11Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go	94.9%	94.7%	-0.3
pkg/reconciler/taskrun/resources/output_resource.go	89.1%	87.0%	-2.2
pkg/reconciler/taskrun/taskrun.go	83.6%	83.9%	0.3
pkg/reconciler/taskrun/validate_resources.go	98.5%	98.1%	-0.4

tekton-robot · 2023-01-18T02:40:10Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1beta1/pipeline_validation.go	99.6%	97.9%	-1.7
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go	94.9%	94.7%	-0.3
pkg/reconciler/taskrun/resources/output_resource.go	89.1%	87.0%	-2.2
pkg/reconciler/taskrun/taskrun.go	83.6%	83.9%	0.3
pkg/reconciler/taskrun/validate_resources.go	98.5%	98.1%	-0.4

tekton-robot · 2023-01-18T02:43:03Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1beta1/pipeline_validation.go	99.6%	97.9%	-1.7
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go	94.9%	94.7%	-0.3
pkg/reconciler/taskrun/resources/output_resource.go	89.1%	87.0%	-2.2
pkg/reconciler/taskrun/taskrun.go	83.6%	83.9%	0.3
pkg/reconciler/taskrun/validate_resources.go	98.5%	98.1%	-0.4

tekton-robot · 2023-01-18T03:49:59Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1beta1/pipeline_validation.go	99.6%	97.9%	-1.7
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go	94.9%	94.7%	-0.3
pkg/reconciler/taskrun/resources/output_resource.go	89.1%	87.0%	-2.2
pkg/reconciler/taskrun/taskrun.go	83.6%	83.9%	0.3
pkg/reconciler/taskrun/validate_resources.go	98.5%	98.1%	-0.4

tekton-robot · 2023-01-18T03:52:27Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1beta1/pipeline_validation.go	99.6%	97.9%	-1.7
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go	94.9%	94.7%	-0.3
pkg/reconciler/taskrun/resources/output_resource.go	89.1%	87.0%	-2.2
pkg/reconciler/taskrun/taskrun.go	83.6%	83.9%	0.3
pkg/reconciler/taskrun/validate_resources.go	98.5%	98.1%	-0.4

tekton-robot · 2023-01-18T04:04:40Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1beta1/pipeline_validation.go	99.6%	97.9%	-1.7
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go	94.9%	94.7%	-0.3
pkg/reconciler/taskrun/resources/output_resource.go	89.1%	87.0%	-2.2
pkg/reconciler/taskrun/taskrun.go	83.6%	83.9%	0.3
pkg/reconciler/taskrun/validate_resources.go	98.5%	98.1%	-0.4

tekton-robot · 2023-01-18T04:08:35Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1beta1/pipeline_validation.go	99.6%	97.9%	-1.7
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go	94.9%	94.7%	-0.3
pkg/reconciler/taskrun/resources/output_resource.go	89.1%	87.0%	-2.2
pkg/reconciler/taskrun/taskrun.go	83.6%	83.9%	0.3
pkg/reconciler/taskrun/validate_resources.go	98.5%	98.1%	-0.4

tekton-robot · 2023-01-18T04:37:33Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1beta1/pipeline_validation.go	99.6%	97.9%	-1.7
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go	94.9%	94.7%	-0.3
pkg/reconciler/taskrun/resources/output_resource.go	89.1%	87.0%	-2.2
pkg/reconciler/taskrun/taskrun.go	83.6%	83.9%	0.3
pkg/reconciler/taskrun/validate_resources.go	98.5%	98.1%	-0.4

tekton-robot · 2023-01-18T04:40:52Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1beta1/pipeline_validation.go	99.6%	97.9%	-1.7
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go	94.9%	94.7%	-0.3
pkg/reconciler/taskrun/resources/output_resource.go	89.1%	87.0%	-2.2
pkg/reconciler/taskrun/taskrun.go	83.6%	83.9%	0.3
pkg/reconciler/taskrun/validate_resources.go	98.5%	98.1%	-0.4

docs/resources.md

tekton-robot · 2023-01-19T18:23:46Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1beta1/pipeline_validation.go	99.6%	97.9%	-1.7
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go	94.9%	94.7%	-0.3
pkg/reconciler/taskrun/resources/output_resource.go	89.1%	87.0%	-2.2
pkg/reconciler/taskrun/taskrun.go	83.6%	83.9%	0.3
pkg/reconciler/taskrun/validate_resources.go	98.5%	98.1%	-0.4

tekton-robot · 2023-01-19T18:28:03Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1beta1/pipeline_validation.go	99.6%	97.9%	-1.7
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go	94.9%	94.7%	-0.3
pkg/reconciler/taskrun/resources/output_resource.go	89.1%	87.0%	-2.2
pkg/reconciler/taskrun/taskrun.go	83.6%	83.9%	0.3
pkg/reconciler/taskrun/validate_resources.go	98.5%	98.1%	-0.4

tekton-robot · 2023-02-23T15:27:26Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1beta1/pipeline_validation.go	99.6%	97.9%	-1.7
pkg/reconciler/taskrun/resources/output_resource.go	89.1%	87.0%	-2.2
pkg/reconciler/taskrun/taskrun.go	84.5%	84.8%	0.3
pkg/reconciler/taskrun/validate_resources.go	98.5%	98.2%	-0.4

tekton-robot · 2023-02-23T15:28:48Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1beta1/pipeline_validation.go	99.6%	97.9%	-1.7
pkg/reconciler/taskrun/resources/output_resource.go	89.1%	87.0%	-2.2
pkg/reconciler/taskrun/taskrun.go	84.5%	84.8%	0.3
pkg/reconciler/taskrun/validate_resources.go	98.5%	98.2%	-0.4

tekton-robot · 2023-02-23T15:55:51Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/taskrun/taskrun.go	84.5%	84.8%	0.3
pkg/reconciler/taskrun/validate_resources.go	98.5%	98.2%	-0.4

tekton-robot · 2023-02-23T15:56:07Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/taskrun/taskrun.go	84.5%	84.8%	0.3
pkg/reconciler/taskrun/validate_resources.go	98.5%	98.2%	-0.4

tekton-robot · 2023-02-23T16:30:36Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/taskrun/taskrun.go	84.5%	84.8%	0.3
pkg/reconciler/taskrun/validate_resources.go	98.5%	98.2%	-0.4

tekton-robot · 2023-02-23T16:35:01Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/taskrun/taskrun.go	84.5%	84.8%	0.3
pkg/reconciler/taskrun/validate_resources.go	98.5%	98.2%	-0.4

pkg/reconciler/pipelinerun/resources/pipelinerunresolution_test.go

pkg/reconciler/taskrun/taskrun_test.go

test/ko_test.go

examples/v1beta1/taskruns/optional-resources-with-clustertask.yaml

tekton-robot · 2023-02-23T19:43:49Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/taskrun/taskrun.go	84.5%	84.8%	0.3
pkg/reconciler/taskrun/validate_resources.go	98.5%	98.2%	-0.4

tekton-robot · 2023-02-23T19:45:47Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/taskrun/taskrun.go	84.5%	84.8%	0.3
pkg/reconciler/taskrun/validate_resources.go	98.5%	98.2%	-0.4

tekton-robot · 2023-02-23T20:19:50Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/taskrun/taskrun.go	84.5%	84.8%	0.3
pkg/reconciler/taskrun/validate_resources.go	98.5%	98.2%	-0.4

tekton-robot · 2023-02-23T20:20:40Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/taskrun/taskrun.go	84.5%	84.8%	0.3
pkg/reconciler/taskrun/validate_resources.go	98.5%	98.2%	-0.4

This commit removes the Image Resources support. This PR removes the imageDigestExporter and the docs for image resources. It also removes the integration tests that test building against image resources.

tekton-robot · 2023-02-24T16:04:00Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/taskrun/taskrun.go	84.5%	84.8%	0.3
pkg/reconciler/taskrun/validate_resources.go	98.5%	98.2%	-0.4

tekton-robot · 2023-02-24T16:05:48Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/taskrun/taskrun.go	84.5%	84.8%	0.3
pkg/reconciler/taskrun/validate_resources.go	98.5%	98.2%	-0.4

lbernick · 2023-02-24T16:08:16Z

/lgtm

JeromeJu · 2023-02-24T16:53:02Z

/test pull-tekton-pipeline-beta-integration-tests

tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 17, 2023

tekton-robot requested review from abayer and dibyom January 17, 2023 23:35

JeromeJu force-pushed the rm-image-resources branch from f825d3b to 3022ba4 Compare January 18, 2023 02:35

tekton-robot added release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. kind/misc Categorizes issue or PR as a miscellaneuous one. and removed release-note-none Denotes a PR that doesnt merit a release note. labels Jan 18, 2023

JeromeJu force-pushed the rm-image-resources branch from 9958f7b to 179aedd Compare January 18, 2023 04:32

lbernick approved these changes Jan 18, 2023

View reviewed changes

docs/resources.md Outdated Show resolved Hide resolved

tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 18, 2023

vdemeester approved these changes Jan 19, 2023

View reviewed changes

JeromeJu mentioned this pull request Jan 19, 2023

[TEP074] Remove CloudEvent pipelineResources #5995

Merged

6 tasks

JeromeJu force-pushed the rm-image-resources branch from 179aedd to 2bb6769 Compare January 19, 2023 18:16

tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 19, 2023

JeromeJu force-pushed the rm-image-resources branch from 2bb6769 to 37aeedd Compare January 19, 2023 18:17

tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 19, 2023

tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 19, 2023

tekton-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 22, 2023

JeromeJu force-pushed the rm-image-resources branch 2 times, most recently from a382bc3 to 3976cd6 Compare February 23, 2023 15:21

JeromeJu force-pushed the rm-image-resources branch from 3976cd6 to 974607a Compare February 23, 2023 15:48

JeromeJu force-pushed the rm-image-resources branch from 974607a to 333cde6 Compare February 23, 2023 16:23

JeromeJu requested review from lbernick and removed request for abayer and dibyom February 23, 2023 18:02

lbernick reviewed Feb 23, 2023

View reviewed changes

JeromeJu force-pushed the rm-image-resources branch from 333cde6 to ea0cbb6 Compare February 23, 2023 19:37

JeromeJu force-pushed the rm-image-resources branch from ea0cbb6 to a2eb236 Compare February 23, 2023 20:13

Remove Image Resources

a47775f

This commit removes the Image Resources support. This PR removes the imageDigestExporter and the docs for image resources. It also removes the integration tests that test building against image resources.

JeromeJu force-pushed the rm-image-resources branch from a2eb236 to a47775f Compare February 24, 2023 15:58

tekton-robot assigned lbernick Feb 24, 2023

tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 24, 2023

tekton-robot merged commit 3ca8444 into tektoncd:main Feb 24, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[TEP074] Remove Image pipelineResources #6002

[TEP074] Remove Image pipelineResources #6002

JeromeJu commented Jan 17, 2023 •

edited

Loading

tekton-robot commented Jan 17, 2023

tekton-robot commented Jan 17, 2023

tekton-robot commented Jan 18, 2023

tekton-robot commented Jan 18, 2023

tekton-robot commented Jan 18, 2023

tekton-robot commented Jan 18, 2023

tekton-robot commented Jan 18, 2023

tekton-robot commented Jan 18, 2023

tekton-robot commented Jan 18, 2023

tekton-robot commented Jan 18, 2023

tekton-robot commented Jan 19, 2023

tekton-robot commented Jan 19, 2023

tekton-robot commented Feb 23, 2023

tekton-robot commented Feb 23, 2023

tekton-robot commented Feb 23, 2023

tekton-robot commented Feb 23, 2023

tekton-robot commented Feb 23, 2023

tekton-robot commented Feb 23, 2023

tekton-robot commented Feb 23, 2023

tekton-robot commented Feb 23, 2023

tekton-robot commented Feb 23, 2023

tekton-robot commented Feb 23, 2023

tekton-robot commented Feb 24, 2023

tekton-robot commented Feb 24, 2023

lbernick commented Feb 24, 2023

JeromeJu commented Feb 24, 2023

[TEP074] Remove Image pipelineResources #6002

[TEP074] Remove Image pipelineResources #6002

Conversation

JeromeJu commented Jan 17, 2023 • edited Loading

Changes

Submitter Checklist

Release Notes

tekton-robot commented Jan 17, 2023

tekton-robot commented Jan 17, 2023

tekton-robot commented Jan 18, 2023

tekton-robot commented Jan 18, 2023

tekton-robot commented Jan 18, 2023

tekton-robot commented Jan 18, 2023

tekton-robot commented Jan 18, 2023

tekton-robot commented Jan 18, 2023

tekton-robot commented Jan 18, 2023

tekton-robot commented Jan 18, 2023

tekton-robot commented Jan 19, 2023

tekton-robot commented Jan 19, 2023

tekton-robot commented Feb 23, 2023

tekton-robot commented Feb 23, 2023

tekton-robot commented Feb 23, 2023

tekton-robot commented Feb 23, 2023

tekton-robot commented Feb 23, 2023

tekton-robot commented Feb 23, 2023

tekton-robot commented Feb 23, 2023

tekton-robot commented Feb 23, 2023

tekton-robot commented Feb 23, 2023

tekton-robot commented Feb 23, 2023

tekton-robot commented Feb 24, 2023

tekton-robot commented Feb 24, 2023

lbernick commented Feb 24, 2023

JeromeJu commented Feb 24, 2023

JeromeJu commented Jan 17, 2023 •

edited

Loading