[TEP-0089] SPIRE for non-falsifiable provenance. Setup the test environment. #6553
Conversation
|
/kind feature |
tekton-robot
added
kind/feature
tekton-robot
added
the
size/XL
tekton-robot
added
the
do-not-merge/work-in-progress
tekton-robot
removed
the
do-not-merge/work-in-progress
|
/retest |
|
/retest-required |
|
Thanks @jerop for the review. Addressed all the comments. |
|
/retest-required |
…onment. This PR is part of a set of PRs to enable non-falsifiable provenance using SPIRE. This PR sets up the environment needed to enable this feature in E2E tests. Note that the SPRIRE flag itself is not enabled, i.e. the feature itself is not enabled. This PR is to test if adding the SPIRE environment does not break anything in E2E tests. Signed-off-by: jagathprakash <31057312+jagathprakash@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jerop The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
There was a problem hiding this comment.
Thanks @jagathprakash !
Can we clean up the PR description a bit? i.e. having a single place to explain the changes, and removing links to the previous individual PRs b/c #6597 includes them all already
| @@ -91,6 +103,7 @@ function run_e2e() { | |||
| fi | |||
| } | |||
|
|
|||
| add_spire "$PIPELINE_FEATURE_GATE" | |||
There was a problem hiding this comment.
Shouldn't this line come after set_feature_gate "$PIPELINE_FEATURE_GATE"?
There was a problem hiding this comment.
The order does not matter as we are not depending on whether spire feature is enabled or not to install SPIRE, which is what add_spire() does.
There was a problem hiding this comment.
But add_spire only installs spire when the alpha feature flag is enabled right? set_feature_gate "$PIPELINE_FEATURE_GATE" is the place where we set alpha feature flag for integration test. If add_spire is called before set_feature_gate, it seems to me the if condition in add_spire will never be met?
There was a problem hiding this comment.
$PIPELINE_FEATURE_GATE is an env variable which is passed in into the e2e-tests.sh script (or rather set before e2e-tests.sh). This can be alpha or stable.
We set the feature flags based on this env variable.
Both add_spire and set_feature_gate depend on this env variable. set_feature_gate sets the feature_flags config based on this env variable.
There was a problem hiding this comment.
aha you're right, my bad. I don't why I ignored the fact the add_spire uses $PIPELINE_FEATURE_GATE as a parameter :/
Thank you for explaining it.
Done. |
|
/lgtm |
1 similar comment
|
/lgtm |
[TEP-0089] SPIRE for non-falsifiable provenance. Setup the test environment.
This PR is part of a set of PRs to enable non-falsifiable provenance using SPIRE. This PR sets up the environment needed to enable this feature in E2E tests. Note that the SPRIRE flag itself is not enabled, i.e. the feature itself is not enabled. This PR is to test if adding the SPIRE environment does not break anything in E2E tests.
Changes
This PR introduces the environment needed to run SPIRE in E2E tests.
Note that the SPIRE feature itself is not enabled.
A tracking bug for this feature, which includes all the PRs added till date, is at
#6597
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes