-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow references to ClusterTasks in v1 Pipeline Tasks #6588
Conversation
We cannot yet remove support for ClusterTasks, so they should continue to be referenceable from v1 Pipelines. This commit removes an error message associated with referencing ClusterTasks in v1 Pipelines.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jerop, Yongxuanzhang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
This needs to be backported in a few releases then (the LTS), at least 0.44.x and 0.47.x I think. |
@vdemeester: GitHub didn't allow me to request PR reviews from the following users: lbernick. Note that only tektoncd members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
I don't think this needs to be backported since #6505 is not part of a release |
Ah I thought it predated #6505, 👌🏼 |
We cannot yet remove support for ClusterTasks, so they should continue to be referenceable from v1 Pipelines. This commit removes an error message associated with referencing ClusterTasks in v1 Pipelines.
Closes #6587
/kind bug
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>
. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes