Clean up metrics code slightly.

[ijschwabacher]

Changes

• Deduplicate some logic that could otherwise get out of sync with itself
• Replace a duration computation for which there is already a method in the stdlib

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

• Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
• Has Tests included if any functionality added or changed
• Follows the commit message standard
• Meets the Tekton contributor standards (including functionality, content, code)
• Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
• Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
• Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: ijschwabacher / name: Isaac Schwabacher (d9f5b22)

[tekton-robot]

Hi @ijschwabacher. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[dibyom]

@ijschwabacher Thanks! Could you sign the CLA?

[dibyom]

/ok-to-test

[dibyom]

/kind misc

[ijschwabacher]

/retest

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/taskrunmetrics/metrics.go	82.8%	83.5%	0.7

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/taskrunmetrics/metrics.go	82.8%	83.5%	0.7

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/taskrunmetrics/metrics.go	82.8%	83.5%	0.7

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/taskrunmetrics/metrics.go	82.8%	83.5%	0.7

[ijschwabacher]

/retest

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/taskrunmetrics/metrics.go	82.8%	83.8%	0.9

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/taskrunmetrics/metrics.go	82.8%	83.8%	0.9

[jerop]

@ijschwabacher thanks for this clean up, and welcome to tekton!

/meow

please squash the commits into one

Use one commit per PR unless there is a strong reason not to ~ standards

[tekton-robot]

@jerop:

In response to this:

@ijschwabacher thanks for this clean up, and welcome to tekton!

/meow

please squash the commits into one

Use one commit per PR unless there is a strong reason not to ~ standards

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[ijschwabacher]

Done.

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/taskrunmetrics/metrics.go	82.8%	83.8%	0.9

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/taskrunmetrics/metrics.go	82.8%	83.8%	0.9

[ijschwabacher]

Is this test a known flake? It's not obvious to me how the change in question could have caused that failure.

[jerop]

Is this test a known flake? It's not obvious to me how the change in question could have caused that failure.

unfortunately yes - #6624

/retest

[ijschwabacher]

I think this is ready for review.

[Yongxuanzhang]

/lgtm

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jerop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jerop]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment