Cleanup: Move array indexing validation out of apis package #6617

lbernick · 2023-05-03T17:58:36Z

We validate that indexing references to array parameters are in bounds,
based on the default values of the parameters and the parameter values
passed in from a PipelineRun/TaskRun. This validation happens in the reconciler,
since it requires comparing the Task/Pipeline spec with the parameters
defined in the TaskRun/PipelineRun.

Prior to this commit, validation code was in the apis package, even though it was called
in the reconciler. This is confusing, because this code cannot be used to validate a Task/Pipeline
spec in isolation; it can only be used in the context of TaskRuns and PipelineRuns.
This commit moves this validation logic to the reconciler and does not introduce any functional changes.

Related: #6607

/kind cleanup

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

n/a Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
Has Tests included if any functionality added or changed
Follows the commit message standard
Meets the Tekton contributor standards (including functionality, content, code)
Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
n/a Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
n/a Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

tekton-robot · 2023-05-03T18:06:04Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1/param_types.go	99.1%	93.1%	-6.0
pkg/apis/pipeline/v1/pipeline_validation.go	99.4%	99.7%	0.3
pkg/apis/pipeline/v1/task_validation.go	96.9%	97.4%	0.5
pkg/apis/pipeline/v1beta1/param_types.go	99.1%	89.0%	-10.0
pkg/apis/pipeline/v1beta1/pipeline_validation.go	99.1%	98.7%	-0.3
pkg/apis/pipeline/v1beta1/task_validation.go	97.0%	97.3%	0.3
pkg/reconciler/pipelinerun/resources/pipelineref.go	93.1%	91.8%	-1.3
pkg/reconciler/pipelinerun/resources/validate_params.go	100.0%	88.5%	-11.5
pkg/reconciler/taskrun/resources/taskref.go	89.7%	88.9%	-0.9
pkg/reconciler/taskrun/resources/validate_params.go	Do not exist	65.2%

tekton-robot · 2023-05-03T18:06:56Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1/param_types.go	99.1%	93.1%	-6.0
pkg/apis/pipeline/v1/pipeline_validation.go	99.4%	99.7%	0.3
pkg/apis/pipeline/v1/task_validation.go	96.9%	97.4%	0.5
pkg/apis/pipeline/v1beta1/param_types.go	99.1%	89.0%	-10.0
pkg/apis/pipeline/v1beta1/pipeline_validation.go	99.1%	98.7%	-0.3
pkg/apis/pipeline/v1beta1/task_validation.go	97.0%	97.3%	0.3
pkg/reconciler/pipelinerun/resources/pipelineref.go	93.1%	91.8%	-1.3
pkg/reconciler/pipelinerun/resources/validate_params.go	100.0%	88.5%	-11.5
pkg/reconciler/taskrun/resources/taskref.go	89.7%	88.9%	-0.9
pkg/reconciler/taskrun/resources/validate_params.go	Do not exist	65.2%

tekton-robot · 2023-05-03T18:07:53Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1/param_types.go	99.1%	93.1%	-6.0
pkg/apis/pipeline/v1/pipeline_validation.go	99.4%	99.7%	0.3
pkg/apis/pipeline/v1/task_validation.go	96.9%	97.4%	0.5
pkg/apis/pipeline/v1beta1/param_types.go	99.1%	89.0%	-10.0
pkg/apis/pipeline/v1beta1/pipeline_validation.go	99.1%	98.7%	-0.3
pkg/apis/pipeline/v1beta1/task_validation.go	97.0%	97.3%	0.3
pkg/reconciler/pipelinerun/resources/pipelineref.go	93.1%	91.8%	-1.3
pkg/reconciler/pipelinerun/resources/validate_params.go	100.0%	88.5%	-11.5
pkg/reconciler/taskrun/resources/taskref.go	89.7%	88.9%	-0.9
pkg/reconciler/taskrun/resources/validate_params.go	Do not exist	65.2%

tekton-robot · 2023-05-03T18:32:45Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1/param_types.go	99.1%	98.4%	-0.7
pkg/apis/pipeline/v1/pipeline_validation.go	99.4%	99.7%	0.3
pkg/apis/pipeline/v1/task_validation.go	96.9%	97.4%	0.5
pkg/apis/pipeline/v1beta1/param_types.go	99.1%	93.8%	-5.3
pkg/apis/pipeline/v1beta1/pipeline_validation.go	99.1%	98.7%	-0.3
pkg/apis/pipeline/v1beta1/task_validation.go	97.0%	97.3%	0.3
pkg/reconciler/pipelinerun/resources/pipelineref.go	93.1%	91.8%	-1.3
pkg/reconciler/taskrun/resources/taskref.go	89.7%	88.9%	-0.9
pkg/reconciler/taskrun/resources/validate_params.go	Do not exist	93.8%

tekton-robot · 2023-05-03T18:35:01Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1/param_types.go	99.1%	98.4%	-0.7
pkg/apis/pipeline/v1/pipeline_validation.go	99.4%	99.7%	0.3
pkg/apis/pipeline/v1/task_validation.go	96.9%	97.4%	0.5
pkg/apis/pipeline/v1beta1/param_types.go	99.1%	93.8%	-5.3
pkg/apis/pipeline/v1beta1/pipeline_validation.go	99.1%	98.7%	-0.3
pkg/apis/pipeline/v1beta1/task_validation.go	97.0%	97.3%	0.3
pkg/reconciler/pipelinerun/resources/pipelineref.go	93.1%	91.8%	-1.3
pkg/reconciler/taskrun/resources/taskref.go	89.7%	88.9%	-0.9
pkg/reconciler/taskrun/resources/validate_params.go	Do not exist	93.8%

Yongxuanzhang

Thanks! This is a huge improvement!
I wonder should we remove these checks as well?

pipeline/pkg/reconciler/taskrun/resources/apply.go

Lines 66 to 69 in 09d422c

    
           if config.CheckAlphaOrBetaAPIFields(ctx) { 
        
           	for i := 0; i < len(p.Default.ArrayVal); i++ { 
        
           		stringReplacements[fmt.Sprintf(pattern+"[%d]", p.Name, i)] = p.Default.ArrayVal[i] 
        
           	}

pipeline/pkg/reconciler/taskrun/resources/apply.go

Lines 109 to 112 in 09d422c

    
           if config.CheckAlphaOrBetaAPIFields(ctx) { 
        
           	for i := 0; i < len(p.Value.ArrayVal); i++ { 
        
           		stringReplacements[fmt.Sprintf(pattern+"[%d]", p.Name, i)] = p.Value.ArrayVal[i] 
        
           	}

pipeline/pkg/reconciler/pipelinerun/resources/apply.go

Lines 67 to 70 in 09d422c

    
           if config.CheckAlphaOrBetaAPIFields(ctx) { 
        
           	for i := 0; i < len(p.Default.ArrayVal); i++ { 
        
           		stringReplacements[fmt.Sprintf(pattern+"[%d]", p.Name, i)] = p.Default.ArrayVal[i] 
        
           	}

pipeline/pkg/reconciler/pipelinerun/resources/apply.go

Lines 118 to 121 in 09d422c

    
           if config.CheckAlphaOrBetaAPIFields(ctx) { 
        
           	for i := 0; i < len(p.Value.ArrayVal); i++ { 
        
           		stringReplacements[fmt.Sprintf(pattern+"[%d]", p.Name, i)] = p.Value.ArrayVal[i] 
        
           	}

pkg/reconciler/taskrun/resources/taskref.go

pkg/reconciler/pipelinerun/resources/validate_params.go

lbernick · 2023-05-03T18:52:44Z

Thanks @Yongxuanzhang I've removed the additional reconciler checks you linked.

tekton-robot · 2023-05-03T19:00:08Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1/param_types.go	99.1%	98.4%	-0.7
pkg/apis/pipeline/v1/pipeline_validation.go	99.4%	99.7%	0.3
pkg/apis/pipeline/v1/task_validation.go	96.9%	97.4%	0.5
pkg/apis/pipeline/v1beta1/param_types.go	99.1%	93.8%	-5.3
pkg/apis/pipeline/v1beta1/pipeline_validation.go	99.1%	98.7%	-0.3
pkg/apis/pipeline/v1beta1/task_validation.go	97.0%	97.3%	0.3
pkg/reconciler/pipelinerun/resources/apply.go	98.1%	98.1%	-0.0
pkg/reconciler/pipelinerun/resources/pipelineref.go	93.1%	91.8%	-1.3
pkg/reconciler/taskrun/resources/apply.go	99.2%	99.2%	-0.0
pkg/reconciler/taskrun/resources/taskref.go	89.7%	88.9%	-0.9
pkg/reconciler/taskrun/resources/validate_params.go	Do not exist	93.8%

tekton-robot · 2023-05-03T19:00:53Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1/param_types.go	99.1%	98.4%	-0.7
pkg/apis/pipeline/v1/pipeline_validation.go	99.4%	99.7%	0.3
pkg/apis/pipeline/v1/task_validation.go	96.9%	97.4%	0.5
pkg/apis/pipeline/v1beta1/param_types.go	99.1%	93.8%	-5.3
pkg/apis/pipeline/v1beta1/pipeline_validation.go	99.1%	98.7%	-0.3
pkg/apis/pipeline/v1beta1/task_validation.go	97.0%	97.3%	0.3
pkg/reconciler/pipelinerun/resources/apply.go	98.1%	98.1%	-0.0
pkg/reconciler/pipelinerun/resources/pipelineref.go	93.1%	91.8%	-1.3
pkg/reconciler/taskrun/resources/apply.go	99.2%	99.2%	-0.0
pkg/reconciler/taskrun/resources/taskref.go	89.7%	88.9%	-0.9
pkg/reconciler/taskrun/resources/validate_params.go	Do not exist	93.8%

lbernick · 2023-05-04T14:54:59Z

@tektoncd/core-maintainers please take a look, this is one of our remaining v1 blockers

Yongxuanzhang

looks good to me! Just have some minor comments/questions.
Let me know when we need a lgtm

pkg/apis/pipeline/v1beta1/param_types.go

pkg/apis/pipeline/v1beta1/task_validation_test.go

pkg/reconciler/taskrun/resources/taskref.go

lbernick · 2023-05-05T16:49:49Z

@Yongxuanzhang done, thanks!

tekton-robot · 2023-05-05T16:54:38Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1/param_types.go	99.1%	98.4%	-0.7
pkg/apis/pipeline/v1/pipeline_validation.go	99.4%	99.7%	0.3
pkg/apis/pipeline/v1/task_validation.go	96.9%	97.4%	0.5
pkg/apis/pipeline/v1beta1/param_types.go	99.1%	93.8%	-5.3
pkg/apis/pipeline/v1beta1/pipeline_validation.go	99.1%	98.7%	-0.3
pkg/apis/pipeline/v1beta1/task_validation.go	97.0%	97.3%	0.3
pkg/reconciler/pipelinerun/resources/apply.go	98.1%	98.1%	-0.0
pkg/reconciler/pipelinerun/resources/pipelineref.go	93.1%	91.8%	-1.3
pkg/reconciler/taskrun/resources/apply.go	99.2%	99.2%	-0.0
pkg/reconciler/taskrun/resources/taskref.go	89.7%	88.9%	-0.9
pkg/reconciler/taskrun/resources/validate_params.go	Do not exist	93.8%

tekton-robot · 2023-05-05T16:56:00Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1/param_types.go	99.1%	98.4%	-0.7
pkg/apis/pipeline/v1/pipeline_validation.go	99.4%	99.7%	0.3
pkg/apis/pipeline/v1/task_validation.go	96.9%	97.4%	0.5
pkg/apis/pipeline/v1beta1/param_types.go	99.1%	93.8%	-5.3
pkg/apis/pipeline/v1beta1/pipeline_validation.go	99.1%	98.7%	-0.3
pkg/apis/pipeline/v1beta1/task_validation.go	97.0%	97.3%	0.3
pkg/reconciler/pipelinerun/resources/apply.go	98.1%	98.1%	-0.0
pkg/reconciler/pipelinerun/resources/pipelineref.go	93.1%	91.8%	-1.3
pkg/reconciler/taskrun/resources/apply.go	99.2%	99.2%	-0.0
pkg/reconciler/taskrun/resources/taskref.go	89.7%	88.9%	-0.9
pkg/reconciler/taskrun/resources/validate_params.go	Do not exist	93.8%

Yongxuanzhang

/lgtm

tekton-robot · 2023-05-19T13:38:58Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1/param_types.go	98.8%	94.1%	-4.7
pkg/apis/pipeline/v1/pipeline_validation.go	99.7%	99.7%	-0.0
pkg/apis/pipeline/v1/task_validation.go	97.3%	97.2%	-0.1
pkg/apis/pipeline/v1beta1/param_types.go	98.8%	94.0%	-4.7
pkg/apis/pipeline/v1beta1/pipeline_validation.go	99.4%	98.8%	-0.6
pkg/apis/pipeline/v1beta1/task_validation.go	97.2%	97.2%	-0.1
pkg/reconciler/taskrun/resources/validate_params.go	Do not exist	93.8%

Yongxuanzhang

/lgtm

pkg/reconciler/taskrun/resources/validate_params.go

tekton-robot · 2023-05-22T13:20:46Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1/param_types.go	98.8%	94.1%	-4.7
pkg/apis/pipeline/v1/pipeline_validation.go	99.7%	99.7%	-0.0
pkg/apis/pipeline/v1/task_validation.go	97.3%	97.2%	-0.1
pkg/apis/pipeline/v1beta1/param_types.go	98.8%	94.0%	-4.7
pkg/apis/pipeline/v1beta1/pipeline_validation.go	99.4%	98.8%	-0.6
pkg/apis/pipeline/v1beta1/task_validation.go	97.2%	97.2%	-0.1
pkg/reconciler/taskrun/resources/validate_params.go	Do not exist	93.3%

tekton-robot · 2023-05-22T13:23:45Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1/param_types.go	98.8%	94.1%	-4.7
pkg/apis/pipeline/v1/pipeline_validation.go	99.7%	99.7%	-0.0
pkg/apis/pipeline/v1/task_validation.go	97.3%	97.2%	-0.1
pkg/apis/pipeline/v1beta1/param_types.go	98.8%	94.0%	-4.7
pkg/apis/pipeline/v1beta1/pipeline_validation.go	99.4%	98.8%	-0.6
pkg/apis/pipeline/v1beta1/task_validation.go	97.2%	97.2%	-0.1
pkg/reconciler/taskrun/resources/validate_params.go	Do not exist	93.3%

pkg/apis/pipeline/v1/param_types.go

tekton-robot · 2023-05-25T23:08:42Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1/param_types.go	98.8%	98.7%	-0.1
pkg/apis/pipeline/v1/pipeline_validation.go	99.7%	99.7%	-0.0
pkg/apis/pipeline/v1/task_validation.go	97.3%	97.3%	-0.1
pkg/apis/pipeline/v1beta1/param_types.go	98.8%	98.7%	-0.1
pkg/apis/pipeline/v1beta1/pipeline_validation.go	99.4%	98.8%	-0.6
pkg/apis/pipeline/v1beta1/task_validation.go	97.2%	97.1%	-0.1
pkg/reconciler/taskrun/resources/validate_params.go	Do not exist	93.3%

tekton-robot · 2023-05-25T23:11:05Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1/param_types.go	98.8%	98.7%	-0.1
pkg/apis/pipeline/v1/pipeline_validation.go	99.7%	99.7%	-0.0
pkg/apis/pipeline/v1/task_validation.go	97.3%	97.3%	-0.1
pkg/apis/pipeline/v1beta1/param_types.go	98.8%	98.7%	-0.1
pkg/apis/pipeline/v1beta1/pipeline_validation.go	99.4%	98.8%	-0.6
pkg/apis/pipeline/v1beta1/task_validation.go	97.2%	97.1%	-0.1
pkg/reconciler/taskrun/resources/validate_params.go	Do not exist	93.3%

We validate that indexing references to array parameters are in bounds, based on the default values of the parameters and the parameter values passed in from a PipelineRun/TaskRun. This validation happens in the reconciler, since it requires comparing the Task/Pipeline spec with the parameters defined in the TaskRun/PipelineRun. Prior to this commit, validation code was in the apis package, even though it was called in the reconciler. This is confusing, because this code cannot be used to validate a Task/Pipeline spec in isolation; it can only be used in the context of TaskRuns and PipelineRuns. This commit moves this validation logic to the reconciler and does not introduce any functional changes.

tekton-robot · 2023-05-31T13:07:48Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1/param_types.go	98.8%	98.7%	-0.1
pkg/apis/pipeline/v1/pipeline_validation.go	99.7%	99.1%	-0.6
pkg/apis/pipeline/v1/task_validation.go	97.3%	97.3%	-0.1
pkg/apis/pipeline/v1beta1/param_types.go	98.8%	98.7%	-0.1
pkg/apis/pipeline/v1beta1/pipeline_validation.go	99.4%	98.8%	-0.6
pkg/apis/pipeline/v1beta1/task_validation.go	97.2%	97.1%	-0.1
pkg/reconciler/taskrun/resources/validate_params.go	Do not exist	93.3%

tekton-robot · 2023-05-31T13:10:51Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1/param_types.go	98.8%	98.7%	-0.1
pkg/apis/pipeline/v1/pipeline_validation.go	99.7%	99.1%	-0.6
pkg/apis/pipeline/v1/task_validation.go	97.3%	97.3%	-0.1
pkg/apis/pipeline/v1beta1/param_types.go	98.8%	98.7%	-0.1
pkg/apis/pipeline/v1beta1/pipeline_validation.go	99.4%	98.8%	-0.6
pkg/apis/pipeline/v1beta1/task_validation.go	97.2%	97.1%	-0.1
pkg/reconciler/taskrun/resources/validate_params.go	Do not exist	93.3%

dibyom · 2023-05-31T16:14:17Z

/approve

tekton-robot · 2023-05-31T16:14:25Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dibyom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [dibyom]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Yongxuanzhang · 2023-05-31T19:11:45Z

/lgtm

Yongxuanzhang · 2023-05-31T19:12:54Z

not sure if the requested changes will block this pr or not, but I think we have split this PR into smaller ones.
cc @jerop

tekton-robot · 2023-05-31T19:23:53Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1/param_types.go	98.8%	98.7%	-0.1
pkg/apis/pipeline/v1/pipeline_validation.go	99.7%	99.1%	-0.6
pkg/apis/pipeline/v1/task_validation.go	97.3%	97.3%	-0.1
pkg/apis/pipeline/v1beta1/param_types.go	98.8%	98.7%	-0.1
pkg/apis/pipeline/v1beta1/pipeline_validation.go	99.4%	98.8%	-0.6
pkg/apis/pipeline/v1beta1/task_validation.go	97.2%	97.1%	-0.1
pkg/reconciler/taskrun/resources/validate_params.go	Do not exist	93.3%

tekton-robot · 2023-05-31T19:25:32Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1/param_types.go	98.8%	98.7%	-0.1
pkg/apis/pipeline/v1/pipeline_validation.go	99.7%	99.1%	-0.6
pkg/apis/pipeline/v1/task_validation.go	97.3%	97.3%	-0.1
pkg/apis/pipeline/v1beta1/param_types.go	98.8%	98.7%	-0.1
pkg/apis/pipeline/v1beta1/pipeline_validation.go	99.4%	98.8%	-0.6
pkg/apis/pipeline/v1beta1/task_validation.go	97.2%	97.1%	-0.1
pkg/reconciler/taskrun/resources/validate_params.go	Do not exist	93.3%

lbernick · 2023-05-31T20:00:57Z

/retest

tekton-robot added kind/bug Categorizes issue or PR as related to a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 3, 2023

tekton-robot requested review from imjasonh and jerop May 3, 2023 17:58

lbernick force-pushed the array-indexing branch from b7e592f to 5989fc5 Compare May 3, 2023 18:00

lbernick assigned vdemeester, dibyom and Yongxuanzhang May 3, 2023

lbernick force-pushed the array-indexing branch from 5989fc5 to 6d644e2 Compare May 3, 2023 18:27

Yongxuanzhang reviewed May 3, 2023

View reviewed changes

pkg/reconciler/taskrun/resources/taskref.go Outdated Show resolved Hide resolved

pkg/reconciler/pipelinerun/resources/validate_params.go Outdated Show resolved Hide resolved

lbernick force-pushed the array-indexing branch from 6d644e2 to 37b4e06 Compare May 3, 2023 18:52

lbernick unassigned vdemeester May 5, 2023

Yongxuanzhang reviewed May 5, 2023

View reviewed changes

pkg/apis/pipeline/v1beta1/param_types.go Outdated Show resolved Hide resolved

pkg/apis/pipeline/v1beta1/task_validation_test.go Outdated Show resolved Hide resolved

pkg/reconciler/taskrun/resources/taskref.go Outdated Show resolved Hide resolved

lbernick force-pushed the array-indexing branch from 37b4e06 to 7adea87 Compare May 5, 2023 16:49

Yongxuanzhang reviewed May 5, 2023

View reviewed changes

tekton-robot added the lgtm Indicates that a PR is ready to be merged. label May 5, 2023

jerop self-assigned this May 8, 2023

Yongxuanzhang reviewed May 19, 2023

View reviewed changes

pkg/reconciler/taskrun/resources/validate_params.go Outdated Show resolved Hide resolved

tekton-robot added the lgtm Indicates that a PR is ready to be merged. label May 19, 2023

lbernick force-pushed the array-indexing branch from 77aaf21 to fc37e4a Compare May 22, 2023 13:15

tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label May 22, 2023

dibyom reviewed May 25, 2023

View reviewed changes

pkg/apis/pipeline/v1/param_types.go Show resolved Hide resolved

pkg/apis/pipeline/v1/param_types.go Show resolved Hide resolved

lbernick force-pushed the array-indexing branch from fc37e4a to 4abcab9 Compare May 25, 2023 23:03

tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 31, 2023

lbernick force-pushed the array-indexing branch from 4abcab9 to 0172d05 Compare May 31, 2023 13:02

tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 31, 2023

tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 31, 2023

lbernick requested a review from Yongxuanzhang May 31, 2023 16:50

tekton-robot added the lgtm Indicates that a PR is ready to be merged. label May 31, 2023

lbernick closed this May 31, 2023

lbernick reopened this May 31, 2023

tekton-robot merged commit 5d5fd5b into tektoncd:main May 31, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Cleanup: Move array indexing validation out of apis package #6617

Cleanup: Move array indexing validation out of apis package #6617

lbernick commented May 3, 2023 •

edited

Loading

tekton-robot commented May 3, 2023

tekton-robot commented May 3, 2023

tekton-robot commented May 3, 2023

tekton-robot commented May 3, 2023

tekton-robot commented May 3, 2023

Yongxuanzhang left a comment •

edited

Loading

lbernick commented May 3, 2023

tekton-robot commented May 3, 2023

tekton-robot commented May 3, 2023

lbernick commented May 4, 2023

Yongxuanzhang left a comment

lbernick commented May 5, 2023

tekton-robot commented May 5, 2023

tekton-robot commented May 5, 2023

Yongxuanzhang left a comment

tekton-robot commented May 19, 2023

Yongxuanzhang left a comment

tekton-robot commented May 22, 2023

tekton-robot commented May 22, 2023

tekton-robot commented May 25, 2023

tekton-robot commented May 25, 2023

tekton-robot commented May 31, 2023

tekton-robot commented May 31, 2023

dibyom commented May 31, 2023

tekton-robot commented May 31, 2023

Yongxuanzhang commented May 31, 2023

Yongxuanzhang commented May 31, 2023

tekton-robot commented May 31, 2023

tekton-robot commented May 31, 2023

lbernick commented May 31, 2023

	if config.CheckAlphaOrBetaAPIFields(ctx) {
	for i := 0; i < len(p.Default.ArrayVal); i++ {
	stringReplacements[fmt.Sprintf(pattern+"[%d]", p.Name, i)] = p.Default.ArrayVal[i]
	}

	if config.CheckAlphaOrBetaAPIFields(ctx) {
	for i := 0; i < len(p.Value.ArrayVal); i++ {
	stringReplacements[fmt.Sprintf(pattern+"[%d]", p.Name, i)] = p.Value.ArrayVal[i]
	}

Cleanup: Move array indexing validation out of apis package #6617

Cleanup: Move array indexing validation out of apis package #6617

Conversation

lbernick commented May 3, 2023 • edited Loading

Submitter Checklist

Release Notes

tekton-robot commented May 3, 2023

tekton-robot commented May 3, 2023

tekton-robot commented May 3, 2023

tekton-robot commented May 3, 2023

tekton-robot commented May 3, 2023

Yongxuanzhang left a comment • edited Loading

Choose a reason for hiding this comment

lbernick commented May 3, 2023

tekton-robot commented May 3, 2023

tekton-robot commented May 3, 2023

lbernick commented May 4, 2023

Yongxuanzhang left a comment

Choose a reason for hiding this comment

lbernick commented May 5, 2023

tekton-robot commented May 5, 2023

tekton-robot commented May 5, 2023

Yongxuanzhang left a comment

Choose a reason for hiding this comment

tekton-robot commented May 19, 2023

Yongxuanzhang left a comment

Choose a reason for hiding this comment

tekton-robot commented May 22, 2023

tekton-robot commented May 22, 2023

tekton-robot commented May 25, 2023

tekton-robot commented May 25, 2023

tekton-robot commented May 31, 2023

tekton-robot commented May 31, 2023

dibyom commented May 31, 2023

tekton-robot commented May 31, 2023

Yongxuanzhang commented May 31, 2023

Yongxuanzhang commented May 31, 2023

tekton-robot commented May 31, 2023

tekton-robot commented May 31, 2023

lbernick commented May 31, 2023

lbernick commented May 3, 2023 •

edited

Loading

Yongxuanzhang left a comment •

edited

Loading