Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Sidecar Containers Construction If Script Exists #6619

Merged
merged 1 commit into from
May 5, 2023

Commits on May 4, 2023

  1. Refactor Sidecar Containers Construction If Script Exists

    Prior to this commit, in order to reuse the code, we convert v1beta1
    Sidecar object to v1beta1.Step and then construct containers out of
    those steps when the script field is specified.
    
    As we are switching the storage version to v1, some fields are
    deprecated in v1.Step (but not Sidecar), thus it does not make sense
    to convert sidercar to step.
    
    While reusing as much code as possible, this commit refactor the code
    to seperate the container construction process for steps and sidecars.
    XinruZhang committed May 4, 2023
    Configuration menu
    Copy the full SHA
    9882a30 View commit details
    Browse the repository at this point in the history