Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor substituting variables in Parameter values #6657

Merged
merged 1 commit into from
May 15, 2023
Merged

Refactor substituting variables in Parameter values #6657

merged 1 commit into from
May 15, 2023

Conversation

jerop
Copy link
Member

@jerop jerop commented May 12, 2023 •
edited
Loading

Changes

This change cleans up the variable replacements for parameter values by creating a member function of Params and adding tests for it. This will allow for further cleanup of the codebase, specifically adding a member function for applying context variables to Params.

/kind cleanup

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 12, 2023
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/param_types.go 99.2% 99.2% 0.0
pkg/apis/pipeline/v1beta1/param_types.go 99.2% 99.2% 0.0
pkg/reconciler/pipelinerun/resources/apply.go 98.1% 98.1% -0.0

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/param_types.go 99.2% 99.2% 0.0
pkg/apis/pipeline/v1beta1/param_types.go 99.2% 99.2% 0.0
pkg/reconciler/pipelinerun/resources/apply.go 98.1% 98.1% -0.0

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/param_types.go 99.2% 99.2% 0.0
pkg/apis/pipeline/v1beta1/param_types.go 99.2% 99.2% 0.0
pkg/reconciler/pipelinerun/resources/apply.go 98.1% 98.1% -0.0

@jerop
Copy link
Member Author

jerop commented May 12, 2023

/retest

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lbernick

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 15, 2023
Yongxuanzhang

This comment was marked as outdated.

Sign in to view

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/param_types.go 99.2% 99.2% 0.0
pkg/apis/pipeline/v1beta1/param_types.go 99.2% 99.2% 0.0
pkg/reconciler/pipelinerun/resources/apply.go 98.1% 98.1% -0.0

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/param_types.go 99.2% 99.2% 0.0
pkg/apis/pipeline/v1beta1/param_types.go 99.2% 99.2% 0.0
pkg/reconciler/pipelinerun/resources/apply.go 98.1% 98.1% -0.0

Yongxuanzhang
Yongxuanzhang reviewed May 15, 2023
View reviewed changes
Copy link
Member

@Yongxuanzhang Yongxuanzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Yongxuanzhang
Yongxuanzhang reviewed May 15, 2023
View reviewed changes
Copy link
Member

@Yongxuanzhang Yongxuanzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels May 15, 2023
@jerop
Refactor substituting variables in Parameter values
6eaccd7 
This change cleans up the variable replacements for parameter values
by creating a member function of `Params` and adding tests for it.

This will allow for further cleanup of the codebase, specifically
adding a member function for applying context variables to Params.
@tekton-robot tekton-robot removed lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels May 15, 2023
@Yongxuanzhang
Copy link
Member

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label May 15, 2023
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/param_types.go 99.2% 99.2% 0.0
pkg/apis/pipeline/v1beta1/param_types.go 99.2% 99.2% 0.0
pkg/reconciler/pipelinerun/resources/apply.go 98.1% 98.1% -0.0

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/param_types.go 99.2% 99.2% 0.0
pkg/apis/pipeline/v1beta1/param_types.go 99.2% 99.2% 0.0
pkg/reconciler/pipelinerun/resources/apply.go 98.1% 98.1% -0.0

@tekton-robot tekton-robot merged commit d6c0f69 into tektoncd:main May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yongxuanzhang Yongxuanzhang Yongxuanzhang left review comments

@lbernick lbernick lbernick approved these changes

@bobcatfish bobcatfish Awaiting requested review from bobcatfish

Assignees

@Yongxuanzhang Yongxuanzhang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jerop @tekton-robot @Yongxuanzhang @lbernick