Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug Fixes: Update Status for Matrixed PipelineTask #6661

Merged
merged 1 commit into from
May 15, 2023
Merged

Bug Fixes: Update Status for Matrixed PipelineTask #6661

merged 1 commit into from
May 15, 2023

Conversation

EmmaMunley
Copy link
Contributor

@EmmaMunley EmmaMunley commented May 15, 2023 •
edited
Loading

Changes

Prior to this commit, we were not checking the status for matrixed tasks and customTasks and only checking that status of singular TaskRun/RunObject. This is a bug since a matrixed PT would not have a nil TaskRun/RunObject since the TaskRuns/RunObjects fields would be used instead. Example functions: AdjustStartTime, IsBeforeFirstTaskRun, isScheduled, isStarted. Added test coverage.

/kind bug

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

Bug Fix: A matrixed pipelineTask will accurately reflect the status of isStarted(), isScheduled(), IsBeforeFirstTaskRun(), IsConditionStatusFalse() with the correct start time based on it's TaskRuns or custom RunObjects.

@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. kind/bug Categorizes issue or PR as related to a bug. labels May 15, 2023
@tekton-robot tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 15, 2023
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go 96.7% 93.8% -2.8
pkg/reconciler/pipelinerun/resources/pipelinerunstate.go 99.5% 94.5% -5.0

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go 96.7% 93.8% -2.8
pkg/reconciler/pipelinerun/resources/pipelinerunstate.go 99.5% 94.5% -5.0

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go 96.7% 93.8% -2.8
pkg/reconciler/pipelinerun/resources/pipelinerunstate.go 99.5% 96.0% -3.5

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go 96.7% 93.8% -2.8
pkg/reconciler/pipelinerun/resources/pipelinerunstate.go 99.5% 96.0% -3.5

jerop
jerop reviewed May 15, 2023
View reviewed changes
Copy link
Member

@jerop jerop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add tests :pray

@tekton-robot tekton-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 15, 2023
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go 96.7% 96.5% -0.2
pkg/reconciler/pipelinerun/resources/pipelinerunstate.go 99.5% 99.5% 0.0

@EmmaMunley EmmaMunley mentioned this pull request May 15, 2023
Merged
7 tasks
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go 96.7% 96.5% -0.2
pkg/reconciler/pipelinerun/resources/pipelinerunstate.go 99.5% 99.5% 0.0

@tekton-robot tekton-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 15, 2023
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go 96.7% 96.6% -0.1
pkg/reconciler/pipelinerun/resources/pipelinerunstate.go 99.5% 99.5% 0.0

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go 96.7% 96.6% -0.1
pkg/reconciler/pipelinerun/resources/pipelinerunstate.go 99.5% 99.5% 0.0

@EmmaMunley
Copy link
Contributor Author

please add tests :pray

Added test cases for IsConditionStatusFalse() and isStarted().

cc: @jerop, @lbernick

lbernick
lbernick approved these changes May 15, 2023
View reviewed changes
Copy link
Member

@lbernick lbernick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@EmmaMunley can you please add a release note for your bug fix?

pkg/reconciler/pipelinerun/resources/pipelinerunresolution_test.go Outdated Show resolved Hide resolved
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lbernick

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 15, 2023
@tekton-robot tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesnt merit a release note. labels May 15, 2023
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go 96.7% 96.6% -0.1
pkg/reconciler/pipelinerun/resources/pipelinerunstate.go 99.5% 99.5% 0.0

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go 96.7% 96.6% -0.1
pkg/reconciler/pipelinerun/resources/pipelinerunstate.go 99.5% 99.5% 0.0

@XinruZhang XinruZhang mentioned this pull request May 15, 2023
Closed
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go 96.7% 96.6% -0.1
pkg/reconciler/pipelinerun/resources/pipelinerunstate.go 99.5% 99.5% 0.0

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go 96.7% 96.6% -0.1
pkg/reconciler/pipelinerun/resources/pipelinerunstate.go 99.5% 99.5% 0.0

Yongxuanzhang
Yongxuanzhang reviewed May 15, 2023
View reviewed changes
Copy link
Member

@Yongxuanzhang Yongxuanzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix and improvements on code, just one quesiont

pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go Show resolved Hide resolved
Yongxuanzhang

This comment was marked as duplicate.

Sign in to view

@EmmaMunley
Bug Fixes: Update Status for Matrixed PipelineTask
a741167 
Prior to this commit, we were not checking the status for matrixed tasks and customTasks and only checking that status of singular TaskRun/RunObject. This is a bug since a matrixed PT would not have a nil TaskRun/RunObject since the TaskRuns/RunObjects fields would be used instead. Example functions: AdjustStartTime, IsBeforeFirstTaskRun, isScheduled, isStarted
@EmmaMunley
Copy link
Contributor Author

Thanks for the fix and improvements on code, just one quesiont

@Yongxuanzhang Good call, updated doc string

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go 96.7% 96.6% -0.1
pkg/reconciler/pipelinerun/resources/pipelinerunstate.go 99.5% 99.5% 0.0

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go 96.7% 96.6% -0.1
pkg/reconciler/pipelinerun/resources/pipelinerunstate.go 99.5% 99.5% 0.0

Yongxuanzhang
Yongxuanzhang reviewed May 15, 2023
View reviewed changes
Copy link
Member

@Yongxuanzhang Yongxuanzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label May 15, 2023
@tekton-robot tekton-robot merged commit e175e6a into tektoncd:main May 15, 2023
@EmmaMunley EmmaMunley deleted the fix-status-matrixed-pt branch May 15, 2023 21:39
@EmmaMunley EmmaMunley mentioned this pull request May 23, 2023
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yongxuanzhang Yongxuanzhang Yongxuanzhang left review comments

@XinruZhang XinruZhang XinruZhang left review comments

@lbernick lbernick lbernick approved these changes

@jerop jerop jerop left review comments

@bobcatfish bobcatfish Awaiting requested review from bobcatfish

@wlynch wlynch Awaiting requested review from wlynch

Assignees

@Yongxuanzhang Yongxuanzhang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@EmmaMunley @tekton-robot @jerop @lbernick @XinruZhang @Yongxuanzhang