-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add validation for beta features in v1 remote Tasks/Pipelines #6725
Conversation
The following is the coverage report on the affected files.
|
The following is the coverage report on the affected files.
|
The following is the coverage report on the affected files.
|
Currently, when a user creates a v1 Task or Pipeline using beta features on their cluster, we validate that "enable-api-fields" is set to "alpha" or "beta", and if not, reject the Task or Pipeline. However, no such validation is done for v1 remote Tasks or Pipelines. This is because we validate remote Task and Pipeline specs in the reconciler after converting them to v1beta1. This commit adds the same validation to remote v1 Tasks and Pipelines that we are already performing for local v1 Tasks and Pipelines.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dibyom, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The following is the coverage report on the affected files.
|
The following is the coverage report on the affected files.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Currently, when a user creates a v1 Task or Pipeline using beta features on their cluster, we validate that "enable-api-fields" is set to "alpha" or "beta", and if not, reject the Task or Pipeline.
However, no such validation is done for v1 remote Tasks or Pipelines. This is because we validate remote Task and Pipeline specs in the reconciler after converting them to v1beta1. This commit adds the same validation to remote v1 Tasks and Pipelines that we are already performing for local v1 Tasks and Pipelines.
/kind bug
Partially addresses #6616
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>
. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes