Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync V1 apis with V1beta1 changes #6766

Merged
merged 1 commit into from
Jun 5, 2023

Conversation

JeromeJu
Copy link
Member

@JeromeJu JeromeJu commented Jun 2, 2023

Changes

This commit syncs v1 apis with v1beta1 changes that are required
by v1 storage swap.

  • it adds the function required ie. IsTimeoutConditionSet()
  • it includes the changes to param_types

No functional changes.

/kind misc
attempt to break #6444 into smaller PRs

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • [n/a] Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • [n/a] Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • [n/a] Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • [n/a] Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. kind/misc Categorizes issue or PR as a miscellaneuous one. labels Jun 2, 2023
@tekton-robot tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 2, 2023
@JeromeJu JeromeJu changed the title Sync v1 apis with v1beta1 changes Sync V1 apis with V1beta1 changes Jun 2, 2023
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/param_types.go 98.7% 98.7% -0.0
pkg/apis/pipeline/v1/pipelinerun_types.go 57.7% 52.8% -4.9

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/param_types.go 98.7% 98.7% -0.0
pkg/apis/pipeline/v1/pipelinerun_types.go 57.7% 52.8% -4.9

@tekton-robot tekton-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 2, 2023
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/param_types.go 98.7% 98.7% -0.0
pkg/apis/pipeline/v1/pipelinerun_types.go 57.7% 89.6% 31.9

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/param_types.go 98.7% 98.7% -0.0
pkg/apis/pipeline/v1/pipelinerun_types.go 57.7% 89.6% 31.9

pkg/apis/pipeline/v1/param_types.go Outdated Show resolved Hide resolved
pkg/apis/pipeline/v1/param_types.go Outdated Show resolved Hide resolved
pkg/apis/pipeline/v1/param_types.go Outdated Show resolved Hide resolved
This commit syncs v1 apis with v1beta1 changes that are required
by v1 storage swap.

- it adds the function required ie. IsTimeoutConditionSet()
- it includes the changes to param_types
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lbernick

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 2, 2023
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/param_types.go 98.7% 98.7% -0.0
pkg/apis/pipeline/v1/pipelinerun_types.go 57.7% 89.6% 31.9

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/param_types.go 98.7% 98.7% -0.0
pkg/apis/pipeline/v1/pipelinerun_types.go 57.7% 89.6% 31.9

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/param_types.go 98.7% 98.7% -0.0
pkg/apis/pipeline/v1/pipelinerun_types.go 57.7% 89.6% 31.9

@JeromeJu
Copy link
Member Author

JeromeJu commented Jun 2, 2023

/retest
possible flake: TestLargerResultsSidecarLogs

opened: #6769

Copy link
Member

@jerop jerop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 5, 2023
@tekton-robot tekton-robot merged commit 87fc1ee into tektoncd:main Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants