Fix v1beta1 pipelineref bundle conversion to resolver

[JeromeJu]

This should be backported to v0.41, v0.44, v0.47

Changes

This commit fixes the bundle conversion for PipelineRef which should
be converting to the bundle Resolver with a Pipeline kind. It also adds
the conversion integration tests for the bundle logics to prevent such
error. It extracts the setup for bundle and makes it into a helper function.

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

• [n/a] Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
• Has Tests included if any functionality added or changed
• Follows the commit message standard
• Meets the Tekton contributor standards (including functionality, content, code)
• Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
• [n/a] Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
• [n/a] Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

[tekton-robot]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lbernick

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [lbernick]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[Yongxuanzhang]

/lgtm

[JeromeJu]

/cherry-pick release-v0.41.x

[JeromeJu]

/cherry-pick release-v0.44.x

[JeromeJu]

/cherry-pick release-v0.41.x

[tekton-robot]

@JeromeJu: #6791 failed to apply on top of branch "release-v0.41.x":

Applying: Fix bundle conversion for pipelineRef
.git/rebase-apply/patch:144: trailing whitespace.
  timeouts: 
.git/rebase-apply/patch:220: trailing whitespace.
  timeouts: 
warning: 2 lines add whitespace errors.
Using index info to reconstruct a base tree...
M	pkg/apis/pipeline/v1beta1/pipelineref_conversion.go
M	pkg/apis/pipeline/v1beta1/pipelinerun_conversion_test.go
A	test/conversion_test.go
M	test/tektonbundles_test.go
Falling back to patching base and 3-way merge...
Auto-merging test/tektonbundles_test.go
CONFLICT (content): Merge conflict in test/tektonbundles_test.go
CONFLICT (modify/delete): test/conversion_test.go deleted in HEAD and modified in Fix bundle conversion for pipelineRef. Version Fix bundle conversion for pipelineRef of test/conversion_test.go left in tree.
Auto-merging pkg/apis/pipeline/v1beta1/pipelinerun_conversion_test.go
Auto-merging pkg/apis/pipeline/v1beta1/pipelineref_conversion.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Fix bundle conversion for pipelineRef
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-v0.41.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[JeromeJu]

/cherry-pick release-v0.44.x

[tekton-robot]

@JeromeJu: #6791 failed to apply on top of branch "release-v0.44.x":

Applying: Fix bundle conversion for pipelineRef
.git/rebase-apply/patch:144: trailing whitespace.
  timeouts: 
.git/rebase-apply/patch:220: trailing whitespace.
  timeouts: 
warning: 2 lines add whitespace errors.
Using index info to reconstruct a base tree...
M	pkg/apis/pipeline/v1beta1/pipelineref_conversion.go
M	pkg/apis/pipeline/v1beta1/pipelinerun_conversion_test.go
M	test/conversion_test.go
M	test/tektonbundles_test.go
Falling back to patching base and 3-way merge...
Auto-merging test/tektonbundles_test.go
Auto-merging test/conversion_test.go
CONFLICT (content): Merge conflict in test/conversion_test.go
Auto-merging pkg/apis/pipeline/v1beta1/pipelinerun_conversion_test.go
Auto-merging pkg/apis/pipeline/v1beta1/pipelineref_conversion.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Fix bundle conversion for pipelineRef
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-v0.44.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[lbernick]

we'll also need to backport to v0.47