Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin the distroless base image to a stable alpine #7356

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

afrittoli
Copy link
Member

Changes

The "latest" tag in the distroless image we use as base image is based on and alpha release of Alpine 3.19_alpha20230901.

Pin the image instead to the latest available version that is based on Alpine 3.18.0 instead.

Fixes: #6456

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

The Tekton images are now based on a distroless base image which is built on top of Alpine 3.18

The "latest" tag in the distroless image we use as base image is based
on and alpha release of Alpine 3.19_alpha20230901.

Pin the image instead to the latest available version that is based on
Alpine 3.18.0 instead.

Fixes: tektoncd#6456

Signed-off-by: Andrea Frittoli <andrea.frittoli@uk.ibm.com>
@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Nov 14, 2023
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 14, 2023
@afrittoli
Copy link
Member Author

/kind misc

@tekton-robot tekton-robot added the kind/misc Categorizes issue or PR as a miscellaneuous one. label Nov 14, 2023
@afrittoli afrittoli closed this Nov 14, 2023
@afrittoli afrittoli reopened this Nov 14, 2023
@afrittoli afrittoli closed this Nov 14, 2023
@afrittoli afrittoli reopened this Nov 14, 2023
@afrittoli afrittoli closed this Nov 14, 2023
@afrittoli afrittoli reopened this Nov 14, 2023
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 14, 2023
@wlynch
Copy link
Member

wlynch commented Nov 14, 2023

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 14, 2023
@tekton-robot tekton-robot merged commit fced45f into tektoncd:main Nov 14, 2023
12 checks passed
@afrittoli
Copy link
Member Author

afrittoli commented Nov 14, 2023

➜ ccat gcr.io/tekton-releases/github.com/tektoncd/pipeline/cmd/entrypoint:v0.53.0 etc/alpine-release
3.19_alpha20230901
➜ ccat gcr.io/tekton-releases/github.com/tektoncd/pipeline/cmd/entrypoint:v0.50.3 etc/alpine-release
3.19_alpha20230901
➜ ccat gcr.io/tekton-releases/github.com/tektoncd/pipeline/cmd/entrypoint:v0.47.3 etc/alpine-release
3.18.0

@afrittoli
Copy link
Member Author

/cherry-pick release-v0.53.x
/cherry-pick release-v0.50.x

@afrittoli afrittoli added the needs-cherry-pick Indicates a PR needs to be cherry-pick to a release branch label Nov 14, 2023
@tekton-robot
Copy link
Collaborator

@afrittoli: new pull request created: #7361

In response to this:

/cherry-pick release-v0.53.x
/cherry-pick release-v0.50.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@afrittoli
Copy link
Member Author

/cherry-pick release-v0.50.x

@tekton-robot
Copy link
Collaborator

@afrittoli: new pull request created: #7362

In response to this:

/cherry-pick release-v0.50.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

afrittoli added a commit to afrittoli/pipeline that referenced this pull request Nov 15, 2023
tektoncd#7356 fixed the images used
by Tekton workloads, but not the controller ones.
Controllers do not support windows, and do not use the combined
image, so the default base image has to be updated too.

Signed-off-by: Andrea Frittoli <andrea.frittoli@uk.ibm.com>
tekton-robot pushed a commit that referenced this pull request Nov 15, 2023
#7356 fixed the images used
by Tekton workloads, but not the controller ones.
Controllers do not support windows, and do not use the combined
image, so the default base image has to be updated too.

Signed-off-by: Andrea Frittoli <andrea.frittoli@uk.ibm.com>
tekton-robot pushed a commit to tekton-robot/pipeline that referenced this pull request Nov 15, 2023
tektoncd#7356 fixed the images used
by Tekton workloads, but not the controller ones.
Controllers do not support windows, and do not use the combined
image, so the default base image has to be updated too.

Signed-off-by: Andrea Frittoli <andrea.frittoli@uk.ibm.com>
tekton-robot pushed a commit to tekton-robot/pipeline that referenced this pull request Nov 15, 2023
tektoncd#7356 fixed the images used
by Tekton workloads, but not the controller ones.
Controllers do not support windows, and do not use the combined
image, so the default base image has to be updated too.

Signed-off-by: Andrea Frittoli <andrea.frittoli@uk.ibm.com>
tekton-robot pushed a commit that referenced this pull request Nov 16, 2023
#7356 fixed the images used
by Tekton workloads, but not the controller ones.
Controllers do not support windows, and do not use the combined
image, so the default base image has to be updated too.

Signed-off-by: Andrea Frittoli <andrea.frittoli@uk.ibm.com>
tekton-robot pushed a commit that referenced this pull request Nov 16, 2023
#7356 fixed the images used
by Tekton workloads, but not the controller ones.
Controllers do not support windows, and do not use the combined
image, so the default base image has to be updated too.

Signed-off-by: Andrea Frittoli <andrea.frittoli@uk.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. needs-cherry-pick Indicates a PR needs to be cherry-pick to a release branch release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use a non-alpha tagged defaultBaseImage image for ko builds
6 participants