-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-v0.47.x] don't return validation error when final tasks failed/skipped #7487
[release-v0.47.x] don't return validation error when final tasks failed/skipped #7487
Conversation
/kind bug |
This commit closes tektoncd#6139, in previous fix PR: tektoncd#6395, only dagTasks statuses are considered and final tasks are missing. This PR fixes this. Signed-off-by: Yongxuan Zhang yongxuanzhang@google.com (cherry picked from commit 7c040de) Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
dff2c2b
to
c11197a
Compare
The following is the coverage report on the affected files.
|
The following is the coverage report on the affected files.
|
Add some missing functions. Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
695526e
to
98067a1
Compare
The following is the coverage report on the affected files.
|
The following is the coverage report on the affected files.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abayer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
Changes
Cherry-pick for 0.47.x of 7407
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>
. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes
/cc @Yongxuanzhang @chitrangpatel @QuanZhang-William