New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can I reproduce it with just the timeout test alone? 🎵 #770

Closed

bobcatfish wants to merge 2 commits into tektoncd:master from bobcatfish:only_timeout

Collaborator

bobcatfish commented Apr 17, 2019 •

edited

Loading

One is the loneliest number
One is the loneliest number
One is the loneliest number that you'll ever do
One is the loneliest
One is the loneliest
One is the loneliest number that you'll ever do

Investigating #731

bobcatfish added 2 commits

April 17, 2019 15:29


          Re-enable flakey test so I can see it in action 🤓

4a43a29


          Can I reproduce it with just the timeout test alone? 🎵

b2968d7

One is the loneliest number
One is the loneliest number
One is the loneliest number that you'll ever do
One is the loneliest
One is the loneliest
One is the loneliest number that you'll ever do

tekton-robot requested review from dlorenc and vdemeester

April 17, 2019 22:39

Collaborator

tekton-robot commented Apr 17, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bobcatfish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [bobcatfish]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

googlebot added the cla: yes label

tekton-robot added approved size/XS labels

Collaborator Author

bobcatfish commented Apr 17, 2019

lol maybe not...

AGAIN

/test pull-tekton-pipeline-integration-tests

Collaborator Author

bobcatfish commented Apr 17, 2019

--- PASS: TestTaskRunTimeout (31.24s)

ಠ_ಠ

Collaborator Author

bobcatfish commented Apr 17, 2019

/test pull-tekton-pipeline-integration-tests

Collaborator Author

bobcatfish commented Apr 17, 2019

I0417 23:21:39.521] === PAUSE TestTaskRunTimeout
I0417 23:21:39.521] === CONT  TestTaskRunTimeout
I0417 23:22:09.642] --- PASS: TestTaskRunTimeout (31.21s)

😩

/test pull-tekton-pipeline-integration-tests

Collaborator Author

bobcatfish commented Apr 17, 2019

/test pull-tekton-pipeline-integration-tests

Collaborator Author

bobcatfish commented Apr 18, 2019

I mean its really seeming like just the one test on its own is never hitting this, I say, based on my sample set of 5.

/test pull-tekton-pipeline-integration-tests

Member

vdemeester commented Apr 18, 2019

I mean its really seeming like just the one test on its own is never hitting this, I say, based on my sample set of 5.

Yes that was kind of my assumption too… when run alone (without any load), it seems to hold on… I think timeout is flakey under medium to heavy load on the controller, somehow

Collaborator Author

bobcatfish commented Apr 18, 2019

/test pull-tekton-pipeline-integration-tests

Collaborator Author

bobcatfish commented Apr 18, 2019

I think timeout is flakey under medium to heavy load on the controller, somehow

I'm wondering if it's something load related too 🤔🤔 🤔 which will be harder to figure out probably. It's weird tho cuz it never seems to happen locally, even using (what I think is) the same cluster setup.

Collaborator Author

bobcatfish commented Apr 18, 2019

via #771 i have a strong theory about what's going on, will update #731 👯‍♀️

bobcatfish closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved cla: yes size/XS