-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bundle resolver can use ServiceAccount for auth #7969
Conversation
The committers listed above are authorized under a signed CLA. |
/kind bug |
Hi @wilstdu. Thanks for your PR. I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The following is the coverage report on the affected files.
|
/ok-to-test |
The following is the coverage report on the affected files.
|
resolverconfig "github.com/tektoncd/pipeline/pkg/apis/config/resolver" | ||
pipelinev1 "github.com/tektoncd/pipeline/pkg/apis/pipeline/v1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😻
How is the status with this PR? Would be awesome to get that in, since I would need that as well! :) |
ping @tektoncd/core-maintainers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chitrangpatel, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
With #7159 change ECR private registry users no longer had an easy option to authenticate with ECR, because ECR uses short-lived credentials (up to 12 hours), therefore adding it to a secret doesn't make sense because it would mean implementing an additional mechanism to secret rotation in each namespace.
Fixes: #7854
Extends: #7159
Tested both variants - GCR (Secret) and ECR (ServiceAccount) private registries.
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>
. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes