Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark steps as deleted when TaskRun fails #8294

Merged
merged 1 commit into from
Sep 25, 2024

Commits on Sep 25, 2024

  1. Mark steps as deleted when TaskRun fails

    Today this is done after the Pod is handled. If Pod deletion fails
    for some reason, the steps are not updated.
    
    Tekton only makes one attempt to delete the Pod to try and avoid
    that it keeps running even if the TaskRun failed. If this deletion
    fails for whatever reason, Tekton should still update the TaskRun
    status to mark the steps as failed, as they are failed from
    Tekton POV.
    
    Fixes: tektoncd#8293
    
    Signed-off-by: Andrea Frittoli <andrea.frittoli@uk.ibm.com>
    afrittoli committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    264be71 View commit details
    Browse the repository at this point in the history