-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initialize PipelineResources in declared order 📝 #970
Conversation
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
@pwittrock was trying to use PipelineResources such that the contents of a GCS bucket could be copied over a previously checked out dir in a github repo. Unfortunately, PipelineResources were being applied in the opposite order that they were declared in! This change makes it so that the PipelineResources will be applied in the declared order, which means that the order these PipelineResources are applied in is now part of our API. Fixes tektoncd#775 Co-authored-by: Eli Zucker <thezuck@google.com>
a555b75
to
ca176ac
Compare
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bobcatfish, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
@pwittrock was trying to use PipelineResources such that the contents of
a GCS bucket could be copied over a previously checked out dir in a
github repo. Unfortunately, PipelineResources were being applied in the
opposite order that they were declared in!
This change makes it so that the PipelineResources will be applied in
the declared order, which means that the order these PipelineResources
are applied in is now part of our API.
Fixes #775
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide
for more details.
Release Notes