-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup condition for ∈ org or "ok-to-test" label before running Tekton based CI jobs #482
Comments
Stale issues rot after 30d of inactivity. /lifecycle rotten Send feedback to tektoncd/plumbing. |
Rotten issues close after 30d of inactivity. /close Send feedback to tektoncd/plumbing. |
@tekton-robot: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/remove-lifecycle rotten |
@vdemeester: Reopened this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lifecycle frozen |
I added a new custom interceptor that adds the required info to the payloads of events, but it is not used yet for CI jobs. |
Precondition for this: #956 |
@afrittoli this can probably be closed right? |
ping @afrittoli is this complete? |
I wrote https://github.com/tektoncd/plumbing/tree/main/tekton/ci/interceptors/add-team-members but it needs to be converted to the "new" format of cluster interceptor https://github.com/tektoncd/plumbing/tree/main/tekton/ci/cluster-interceptors. What that interceptor does is add the list of team members to the extensions, but perhaps we could have more logic implemented in the custom interceptor, i.e. pass in the author and repo and list of labels, and return an authorised decision (true/false). |
Expected Behavior
CI Jobs are only executed if a PR was submitted by someone who belongs to the org or if the "ok-to-test" label was added.
Actual Behavior
CI Jobs are executed regardless.
Additional Info
This avoids letting anyone from outside of the org running arbitrary code in CI checks, and it provides continuity with the functionality available from prow today.
The text was updated successfully, but these errors were encountered: