Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup condition for ∈ org or "ok-to-test" label before running Tekton based CI jobs #482

Open
afrittoli opened this issue Jul 16, 2020 · 11 comments
Labels
area/dogfooding Indicates an issue on dogfooding (aka using Pipeline to test Pipeline) lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.

Comments

@afrittoli
Copy link
Member

Expected Behavior

CI Jobs are only executed if a PR was submitted by someone who belongs to the org or if the "ok-to-test" label was added.

Actual Behavior

CI Jobs are executed regardless.

Additional Info

This avoids letting anyone from outside of the org running arbitrary code in CI checks, and it provides continuity with the functionality available from prow today.

@afrittoli afrittoli added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. area/dogfooding Indicates an issue on dogfooding (aka using Pipeline to test Pipeline) help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Jul 16, 2020
@tekton-robot
Copy link
Contributor

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.

/lifecycle rotten

Send feedback to tektoncd/plumbing.

@tekton-robot
Copy link
Contributor

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Aug 15, 2020
@tekton-robot
Copy link
Contributor

@tekton-robot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

Send feedback to tektoncd/plumbing.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vdemeester
Copy link
Member

/remove-lifecycle rotten
/remove-lifecycle stale
/reopen

@tekton-robot tekton-robot reopened this Aug 17, 2020
@tekton-robot
Copy link
Contributor

@vdemeester: Reopened this issue.

In response to this:

/remove-lifecycle rotten
/remove-lifecycle stale
/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Aug 17, 2020
@afrittoli afrittoli removed the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Oct 12, 2020
@afrittoli
Copy link
Member Author

/lifecycle frozen

@tekton-robot tekton-robot added the lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. label Oct 12, 2020
@afrittoli
Copy link
Member Author

I added a new custom interceptor that adds the required info to the payloads of events, but it is not used yet for CI jobs.

@afrittoli
Copy link
Member Author

Precondition for this: #956

@lbernick
Copy link
Member

@afrittoli this can probably be closed right?

@chitrangpatel
Copy link
Contributor

ping @afrittoli is this complete?

@afrittoli
Copy link
Member Author

I wrote https://github.com/tektoncd/plumbing/tree/main/tekton/ci/interceptors/add-team-members but it needs to be converted to the "new" format of cluster interceptor https://github.com/tektoncd/plumbing/tree/main/tekton/ci/cluster-interceptors.

What that interceptor does is add the list of team members to the extensions, but perhaps we could have more logic implemented in the custom interceptor, i.e. pass in the author and repo and list of labels, and return an authorised decision (true/false).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dogfooding Indicates an issue on dogfooding (aka using Pipeline to test Pipeline) lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
Status: Todo
Status: Todo
Development

No branches or pull requests

5 participants