Add license tools for repositories without vendor directories. #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
the
size/L
Needed for upcoming work for tektoncd/pipeline#1538. This change makes 2 changes to support Go module enabled repos without vendor directories. 1) Use go-licenses instead of dep-collector for third_party license notices. dep-collector makes heavy assumptions about the existence of the vendor directory. go-licenses is a module aware alternative. 2) Ignore the `+build tools` flag when building/testing projects. This is to allow tool dependencies to be specified with Go modules following the recommendation of https://github.com/golang/go/wiki/Modules#how-can-i-track-tool-dependencies-for-a-module.
3 tasks
vdemeester
reviewed
Nov 26, 2019
| @@ -167,7 +167,7 @@ function default_build_test_runner() { | |||
| go build -v ./... || failed=1 | |||
| # Get all build tags in go code (ignore /vendor) | |||
| local tags="$(grep -r '// +build' . \ | |||
| | grep -v '^./vendor/' | cut -f3 -d' ' | sort | uniq | tr '\n' ' ')" | |||
| | grep -v '^./vendor/' | grep -v '^./third_party/' | grep -v "+build tools" | cut -f3 -d' ' | sort | uniq | tr '\n' ' ')" | |||
There was a problem hiding this comment.
@wlynch why the grep -v "+build tools" ?
There was a problem hiding this comment.
This is to exclude packages containing binary dependencies, as specified by https://github.com/golang/go/wiki/Modules#how-can-i-track-tool-dependencies-for-a-module.
Added a comment to document.
vdemeester
approved these changes
Nov 27, 2019
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Needed for upcoming work for
tektoncd/pipeline#1538.
This change makes 2 changes to support Go module enabled repos
without vendor directories.
notices. dep-collector makes heavy assumptions about the existence of
the vendor directory. go-licenses is a module aware alternative.
+build toolsflag when building/testing projects. Thisis to allow tool dependencies to be specified with Go modules following
the recommendation of
https://github.com/golang/go/wiki/Modules#how-can-i-track-tool-dependencies-for-a-module.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide
for more details.