Migrate Triggers e2e test to kind #1252
Conversation
tekton-robot
added
the
size/M
|
/hold I'll try to get tektoncd/triggers#1477 in first |
tekton-robot
added
the
do-not-merge/hold
| @@ -1655,29 +1655,58 @@ presubmits: | |||
| - name: pull-tekton-triggers-integration-tests | |||
| labels: | |||
| preset-presubmit-sh: "true" | |||
| preset-dind-enabled: "true" | |||
| preset-kind-volume-mounts: "true" | |||
| pipeline-kind-e2e: "true" | |||
There was a problem hiding this comment.
We should probably rename this label, since its purpose is to ensure that kind e2e jobs each end up on their own node, regardless of project. But that doesn't need to be done here. =)
There was a problem hiding this comment.
I'll do that as part of #1281
tekton-robot
added
the
approved
This is merged now! |
Yes, keeping the hold for a few more days till we release the next Triggers version and then we'll switch to kind |
|
@dibyom kind reminder about this 🙏 |
I'll pick it back up this week!! |
dibyom
force-pushed
the
triggers-kind
branch
from
2ba9904 to
c2adf0d
Compare
tekton-robot
added
needs-rebase
dibyom
force-pushed
the
triggers-kind
branch
from
c2adf0d to
9dc3786
Compare
tekton-robot
added
size/M
|
/hold cancel |
tekton-robot
removed
the
do-not-merge/hold
|
@abayer @afrittoli ready for another look! |
tekton-robot
added
the
needs-rebase
Follows the guide in docs/kind-e2e.md with a couple of changes to match the current pipeline e2e tests: 1. Use latest builder image for the time being 2. Adds a `pipeline-kind-e2e: "true"` label that is used for podAntiAffinity - we don't want multiple kind jobs running on the same nodes. Part of tektoncd/triggers#1475 Signed-off-by: Dibyo Mukherjee <dibyo@google.com>
tekton-robot
removed
the
needs-rebase
|
just needs a LGTM now @afrittoli @vdemeester 🙏 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abayer, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
Follows the guide in docs/kind-e2e.md with a couple of changes to match the current pipeline e2e tests:
pipeline-kind-e2e: "true"label that is used for podAntiAffinity - we don't want multiple kind jobs running on the same nodes.Part of tektoncd/triggers#1475
/kind misc
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide
for more details.