Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Follow naming conventions for resourceTemplates #1650

Merged
merged 1 commit into from
Oct 30, 2023
Merged

Follow naming conventions for resourceTemplates #1650

merged 1 commit into from
Oct 30, 2023

Conversation

savitaashture
Copy link
Contributor

As per the standards the JSON or YAML keys should follow capitalization but resourcetemplates keys doesn't
follow that.
Changing resourcetemplates to resourceTemplates

Signed-off-by: Savita Ashture sashture@redhat.com"

Changes

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@savitaashture
Follow naming conventions for resourceTemplates
0ccbcd4 
As per the standards the JSON or YAML keys should follow
capitalization but resourcetemplates keys doesn't
follow that.
Changing resourcetemplates to resourceTemplates

Signed-off-by: Savita Ashture <sashture@redhat.com>
@savitaashture savitaashture added the kind/misc Categorizes issue or PR as a miscellaneuous one. label Sep 24, 2023
@tekton-robot tekton-robot added the release-note-none Denotes a PR that doesnt merit a release note. label Sep 24, 2023
@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 24, 2023
khrm
khrm reviewed Sep 24, 2023
View reviewed changes
Copy link
Contributor

@khrm khrm left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What would happen if some resource already exists with that version? Don't we need a conversion function?

@savitaashture
Copy link
Contributor Author

savitaashture commented Sep 24, 2023 •
edited by khrm
Loading

What would happen if some resource already exists with that version? Don't we need a conversion function?

Its not needed because it works for both resourceTemplates and resourcetemplates i have verified

@khrm
Copy link
Contributor

khrm commented Sep 24, 2023

What would happen if some resource already exists with that version? Don't we need a conversion function?

Its not needed because it works for both resourceTemplates and resourcetemplates i have verified

It's working because go default JSON decoder/encoder doesn't care about case or characters like _. So etcd would have two different field names after this pr - older with resourcetemplates and newly created with resourceTemplates.

@savitaashture
Copy link
Contributor Author

What would happen if some resource already exists with that version? Don't we need a conversion function?

Its not needed because it works for both resourceTemplates and resourcetemplates i have verified

It's working because go default JSON decoder/encoder doesn't care about case or characters like _. So etcd would have two different field names after this pr - older with resourcetemplates and newly created with resourceTemplates.

Yes but I think that should be fine right

@dibyom
Copy link
Member

dibyom commented Oct 4, 2023

This seems like the right thing to do - as long as this is not a breaking change i.e. the old style works too

@savitaashture
Copy link
Contributor Author

Hi @dibyom @khrm if PR looks good can you guys review and merge it
Thank you

khrm
khrm reviewed Oct 25, 2023
View reviewed changes
Copy link
Contributor

@khrm khrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: khrm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 25, 2023
@savitaashture savitaashture added this to the Triggers v0.26 milestone Oct 26, 2023
dibyom
dibyom reviewed Oct 30, 2023
View reviewed changes
Copy link
Member

@dibyom dibyom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 30, 2023
@tekton-robot tekton-robot merged commit 447f613 into tektoncd:main Oct 30, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dibyom dibyom dibyom left review comments

@khrm khrm khrm left review comments

@iancoffey iancoffey Awaiting requested review from iancoffey

Assignees

@dibyom dibyom

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
Triggers v0.26
Development

Successfully merging this pull request may close these issues.
4 participants
@savitaashture @khrm @dibyom @tekton-robot