Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix afg burst waveform generation and update get_model_series function #13

Merged
merged 3 commits into from
Sep 29, 2023

Conversation

michaelwagoner
Copy link
Contributor

No description provided.

@michaelwagoner michaelwagoner requested a review from a team as a code owner September 28, 2023 21:32
@michaelwagoner michaelwagoner self-assigned this Sep 28, 2023
@CLAassistant
Copy link

CLAassistant commented Sep 28, 2023

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

Merging #13 (bbed976) into main (59978fe) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main       #13   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          168       168           
  Lines         3745      3756   +11     
  Branches       672       676    +4     
=========================================
+ Hits          3745      3756   +11     
Files Coverage Δ
...c/tm_devices/drivers/pi/signal_sources/afgs/afg.py 100.00% <100.00%> (ø)
src/tm_devices/helpers/functions.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@nfelt14
Copy link
Collaborator

nfelt14 commented Sep 28, 2023

The commits must be signed for them to be able to be added.

@nfelt14
Copy link
Collaborator

nfelt14 commented Sep 28, 2023

Can you change pull_request to pull_request_target in the workflow that assigns reviewers? This will need to be changed to allow the workflow to run properly when triggered by forks.

Copy link
Collaborator

@nfelt14 nfelt14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See previous comments

nfelt14
nfelt14 previously approved these changes Sep 28, 2023
ldantek
ldantek previously approved these changes Sep 28, 2023
@michaelwagoner michaelwagoner merged commit 9116582 into tektronix:main Sep 29, 2023
33 checks passed
nfelt14 pushed a commit that referenced this pull request Sep 29, 2023
#13)

* fix: Fix afg burst waveform generation and update get_model_series function.

* fix: Change pull_request to pull_request_target to allow workflow ot run properly when triggered by forks.
v12ganesh pushed a commit to v12ganesh/tm_devices that referenced this pull request Mar 28, 2024
tektronix#13)

* fix: Fix afg burst waveform generation and update get_model_series function.

* fix: Change pull_request to pull_request_target to allow workflow ot run properly when triggered by forks.
Signed-off-by: v12ganesh ganesh.v@tektronix.com
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants