-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Custom LAN Device Name for TCPIP Connections #267
Merged
nfelt14
merged 18 commits into
tektronix:main
from
lekevin678:kevin.le/custom-lan-device-name
Aug 7, 2024
Merged
feat: Custom LAN Device Name for TCPIP Connections #267
nfelt14
merged 18 commits into
tektronix:main
from
lekevin678:kevin.le/custom-lan-device-name
Aug 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… is only used when connecting to TCPIP. If connection type is TCPIP, default is to use 'inst0';
…me in the config;
…ny lan device name (this follows NI-MAX UI)
nfelt14
requested changes
Aug 6, 2024
nfelt14
requested changes
Aug 6, 2024
|
…ion rather than post init.
…ssion rather than post init.
…78/tm_devices into kevin.le/custom-lan-device-name
nfelt14
requested changes
Aug 6, 2024
nfelt14
previously approved these changes
Aug 7, 2024
lekevin678
temporarily deployed
to
package-build
August 7, 2024 14:38 — with
GitHub Actions
Inactive
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #267 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 152 152
Lines 4821 4822 +1
Branches 769 767 -2
=========================================
+ Hits 4821 4822 +1 ☔ View full report in Codecov by Sentry. |
…ust testing code and linting
…ust testing code and linting
nfelt14
previously approved these changes
Aug 7, 2024
Breaking API Changes
|
Test Results (ubuntu)
|
Test Results (windows)
|
Test Results (macos)
|
nfelt14
approved these changes
Aug 7, 2024
michaelwagoner
approved these changes
Aug 7, 2024
ldantek
reviewed
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Before, TCPIP connections have the LAN device name hard-coded to "'inst0" in the VISA connection string. Not all devices connection on "inst0". For example, some devices connect on High Speed LAN Instrument Protocol (HiSLIP) with the LAN device name of "hislip0". Added
lan_device_name
as an optional string toDeviceConfigEntry
to allow connections on different LAN device names.Types of changes
What types of changes does your code introduce?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.