Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Custom LAN Device Name for TCPIP Connections #267

Merged
merged 18 commits into from
Aug 7, 2024

Conversation

lekevin678
Copy link
Contributor

@lekevin678 lekevin678 commented Aug 6, 2024

Proposed changes

Before, TCPIP connections have the LAN device name hard-coded to "'inst0" in the VISA connection string. Not all devices connection on "inst0". For example, some devices connect on High Speed LAN Instrument Protocol (HiSLIP) with the LAN device name of "hislip0". Added lan_device_name as an optional string to DeviceConfigEntry to allow connections on different LAN device names.

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Functionality update (non-breaking change which updates or changes existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • CI/CD update (an update to the CI/CD workflows, scripts, and/or configurations)
  • Documentation update (an update to enhance the user experience when reading through the docs)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have followed the guidelines in the CONTRIBUTING document
  • I have signed the CLA
  • I have checked to ensure there aren't other open Pull Requests for the same update/change
  • I have performed a self-review of my code
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • Basic linting passes locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have added necessary documentation (if appropriate)
  • I have updated the Changelog with a brief description of my changes

@lekevin678 lekevin678 requested review from a team as code owners August 6, 2024 19:23
@nfelt14 nfelt14 added the enhancement New feature or request label Aug 6, 2024
docs/configuration.md Outdated Show resolved Hide resolved
tests/test_device_manager.py Outdated Show resolved Hide resolved
@nfelt14
Copy link
Collaborator

nfelt14 commented Aug 6, 2024

  • The branch needs to be rebased with the latest from main

nfelt14
nfelt14 previously approved these changes Aug 7, 2024
@nfelt14 nfelt14 enabled auto-merge (squash) August 7, 2024 14:39
Copy link

codecov bot commented Aug 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (b9f6f96) to head (87b29b0).
Report is 50 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #267   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          152       152           
  Lines         4821      4822    +1     
  Branches       769       767    -2     
=========================================
+ Hits          4821      4822    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

nfelt14
nfelt14 previously approved these changes Aug 7, 2024
Copy link

github-actions bot commented Aug 7, 2024

Breaking API Changes

src/tm_devices/helpers/constants_and_dataclasses.py:0: DeviceConfigEntry.__init__(serial_config):
Positional parameter was moved
  Details: position: from 6 to 7 (+1)

src/tm_devices/helpers/constants_and_dataclasses.py:0: DeviceConfigEntry.__init__(device_driver):
Positional parameter was moved
  Details: position: from 7 to 8 (+1)

src/tm_devices/helpers/constants_and_dataclasses.py:0: DeviceConfigEntry.__init__(gpib_board_number):
Positional parameter was moved
  Details: position: from 8 to 9 (+1)

Link to workflow run

@nfelt14 nfelt14 enabled auto-merge (squash) August 7, 2024 16:07
Copy link

github-actions bot commented Aug 7, 2024

Test Results (ubuntu)

path passed subtotal
tests/test_afgs.py 2 2
tests/test_alias_dict.py 1 1
tests/test_all_device_drivers.py 1 1
tests/test_alternative_connection_addresses.py 19 19
tests/test_awgs.py 4 4
tests/test_config_parser.py 38 38
tests/test_device_manager.py 18 18
tests/test_devices_legacy_tsp_ieee_cmds.py 3 3
tests/test_generate_waveform.py 6 6
tests/test_helpers.py 71 71
tests/test_ieee_scpi_cmds.py 1 1
tests/test_margin_testers.py 5 5
tests/test_pi_device.py 1 1
tests/test_psu.py 1 1
tests/test_rest_api_device.py 10 10
tests/test_scopes.py 7 7
tests/test_singleton.py 1 1
tests/test_smu.py 4 4
tests/test_ss.py 1 1
tests/test_tm_devices.py 4 4
tests/test_unsupported_device_type.py 1 1
TOTAL 199 199

Link to workflow run

Copy link

github-actions bot commented Aug 7, 2024

Test Results (windows)

path passed subtotal
tests\test_afgs.py 2 2
tests\test_alias_dict.py 1 1
tests\test_all_device_drivers.py 1 1
tests\test_alternative_connection_addresses.py 19 19
tests\test_awgs.py 4 4
tests\test_config_parser.py 38 38
tests\test_device_manager.py 18 18
tests\test_devices_legacy_tsp_ieee_cmds.py 3 3
tests\test_generate_waveform.py 6 6
tests\test_helpers.py 71 71
tests\test_ieee_scpi_cmds.py 1 1
tests\test_margin_testers.py 5 5
tests\test_pi_device.py 1 1
tests\test_psu.py 1 1
tests\test_rest_api_device.py 10 10
tests\test_scopes.py 7 7
tests\test_singleton.py 1 1
tests\test_smu.py 4 4
tests\test_ss.py 1 1
tests\test_tm_devices.py 4 4
tests\test_unsupported_device_type.py 1 1
TOTAL 199 199

Link to workflow run

Copy link

github-actions bot commented Aug 7, 2024

Test Results (macos)

path passed subtotal
tests/test_afgs.py 2 2
tests/test_alias_dict.py 1 1
tests/test_all_device_drivers.py 1 1
tests/test_alternative_connection_addresses.py 19 19
tests/test_awgs.py 4 4
tests/test_config_parser.py 38 38
tests/test_device_manager.py 18 18
tests/test_devices_legacy_tsp_ieee_cmds.py 3 3
tests/test_generate_waveform.py 6 6
tests/test_helpers.py 71 71
tests/test_ieee_scpi_cmds.py 1 1
tests/test_margin_testers.py 5 5
tests/test_pi_device.py 1 1
tests/test_psu.py 1 1
tests/test_rest_api_device.py 10 10
tests/test_scopes.py 7 7
tests/test_singleton.py 1 1
tests/test_smu.py 4 4
tests/test_ss.py 1 1
tests/test_tm_devices.py 4 4
tests/test_unsupported_device_type.py 1 1
TOTAL 199 199

Link to workflow run

@nfelt14 nfelt14 merged commit 42c47e6 into tektronix:main Aug 7, 2024
64 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants