Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Incorrect package name #27841

Merged
merged 3 commits into from
May 3, 2024
Merged

fix: Incorrect package name #27841

merged 3 commits into from
May 3, 2024

Conversation

popey
Copy link
Contributor

@popey popey commented May 2, 2024

@CLAassistant
Copy link

CLAassistant commented May 2, 2024

CLA assistant check
All committers have signed the CLA.

@Aokromes
Copy link
Collaborator

Aokromes commented May 2, 2024

@popey
Copy link
Contributor Author

popey commented May 2, 2024

Ok, but the snap builds inside Ubuntu usually, this change only affects the snap.

@ilya-fedin
Copy link
Contributor

ilya-fedin commented May 2, 2024

@popey btw maybe you know how to enable riscv64 builds on launchpad and build.snapcraft.io? I see core22 and core24 have riscv64 builds but canonical builders don't even try to build tdesktop for it despite snapcraft.yml has no architecture restrictions.

I thought you have quit snap for flatpak but if you returned... maybe I can ask you more questions privately via Telegram (what's your username?)?

The package has been updated for 2038 t64 update. This fixes that. 

Successfully build telegram 5.0.0 in arm64 after the fixes in this PR.
@popey
Copy link
Contributor Author

popey commented May 2, 2024

On the subject of riscv64:

snapcraft remote-build --build-for=riscv64

I just kicked one off as a test - which I fully expect to fail. It's 'currently building' on launchpad right now.

https://launchpad.net/~popey/popey-craft-remote-build/+snap/snapcraft-telegram-asahi-db4b99270893b00bc1a00a30fe11bf4e

Screenshot, just because if (when) the build fails the above link will likely break.

image

I'm popeydc on telegram. Feel free to dm me about this kind of thing. Happy to help. I have no idea how to make flatpaks :D

The reason it worked without explicitly updating this one is because the deb of libgtk-3-0t64 has a 'replaces' line for libgtk-3-0 - which nullifies this entry, as both were specified. But, you're right, looks better to have the right package in there.
@ilya-fedin
Copy link
Contributor

There's no sign of riscv64 here: https://launchpad.net/~telegram.desktop/+snap/telegram-desktop-master/

And preston was sharing screenshots of build.snapcraft.io where it doesn't even try to build for riscv64 just as well

@popey
Copy link
Contributor Author

popey commented May 2, 2024

I suspect that riscv64 isn't on by default for builds which use 'all' architectures.
The docs say you can force it with --build-for=amd64,arm64,armhf,ppcel64,s390x,riscv64

Be aware the riscv64 builds take 3-5 times longer than other architectures. They're very slow - I suspect qemu - build bots.

however there appears to be a bug here.

Found the bug: canonical/snapcraft#4780

@ilya-fedin
Copy link
Contributor

I suspect that riscv64 isn't on by default for builds which use 'all' architectures.

It's ok then... Thought maybe there's some architecture choice on launchpad/snapcraft.io as well...

@john-preston john-preston merged commit e3a14d4 into telegramdesktop:dev May 3, 2024
1 check passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants