-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Incorrect package name #27841
fix: Incorrect package name #27841
Conversation
Noble has libvpx9, not vpx8. https://packages.ubuntu.com/search?keywords=libvpx9
Ok, but the snap builds inside Ubuntu usually, this change only affects the snap. |
@popey btw maybe you know how to enable riscv64 builds on launchpad and build.snapcraft.io? I see core22 and core24 have riscv64 builds but canonical builders don't even try to build tdesktop for it despite snapcraft.yml has no architecture restrictions. I thought you have quit snap for flatpak but if you returned... maybe I can ask you more questions privately via Telegram (what's your username?)? |
The package has been updated for 2038 t64 update. This fixes that. Successfully build telegram 5.0.0 in arm64 after the fixes in this PR.
On the subject of riscv64:
I just kicked one off as a test - which I fully expect to fail. It's 'currently building' on launchpad right now. Screenshot, just because if (when) the build fails the above link will likely break. I'm popeydc on telegram. Feel free to dm me about this kind of thing. Happy to help. I have no idea how to make flatpaks :D |
The reason it worked without explicitly updating this one is because the deb of libgtk-3-0t64 has a 'replaces' line for libgtk-3-0 - which nullifies this entry, as both were specified. But, you're right, looks better to have the right package in there.
There's no sign of riscv64 here: https://launchpad.net/~telegram.desktop/+snap/telegram-desktop-master/ And preston was sharing screenshots of build.snapcraft.io where it doesn't even try to build for riscv64 just as well |
I suspect that riscv64 isn't on by default for builds which use 'all' architectures. Be aware the riscv64 builds take 3-5 times longer than other architectures. They're very slow - I suspect qemu - build bots. however there appears to be a bug here. Found the bug: canonical/snapcraft#4780 |
It's ok then... Thought maybe there's some architecture choice on launchpad/snapcraft.io as well... |
Noble has libvpx9, not vpx8.
https://packages.ubuntu.com/search?keywords=libvpx9