Update regexp patterns for telnet #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* comment adding patterns * update regexp pattern * add timeout for telnet and pattern fixed * remove extra lines * update test csses ---------
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This request contains several updates that we had to make during the recording of telnet communications with Cisco 12k router.
Update of regexp patterns
While recording of telnet communications we faced some false positive regexp matching that mistakenly considered some output as an end of line
Update of test cases
Relevant test cases from the previous point were added
Add timeout for telnet connection
Explicit timeout for telnet expect method were added. Without it we faced stuck of recording process for some long lasting telnet operations executions