fix: comment hardcoded value and add todo

telekom · Sep 21, 2023 · 0b0c9c3 · 0b0c9c3
1 parent 90bada6
commit 0b0c9c3
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/packages/components/src/components/telekom/telekom-header/telekom-header.tsx b/packages/components/src/components/telekom/telekom-header/telekom-header.tsx
@@ -47,6 +47,8 @@ export class TelekomHeader {
 
   @Listen('scroll', { target: 'document' })
   onScroll() {
+    // 48px is the height of the header, set scrolled when the user scrolls past it
+    // todo: calculate this value dynamically (for slim header, smaller viewports, etc)
     this.scrolled = window.pageYOffset > 48;
     this.scrolledBack =
       this.pageYOffset !== window.pageYOffset && window.pageYOffset <= 0;