Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update parent checkbox state when new children are added dynamically #2145

Merged
merged 5 commits into from
Oct 12, 2023

Conversation

felix-ico
Copy link
Collaborator

fixes #1774

@netlify
Copy link

netlify bot commented Sep 25, 2023

Deploy Preview for marvelous-moxie-a6e2fe ready!

Name Link
🔨 Latest commit ea47540
🔍 Latest deploy log https://app.netlify.com/sites/marvelous-moxie-a6e2fe/deploys/651d3854b2e8370008a46cc3
😎 Deploy Preview https://deploy-preview-2145--marvelous-moxie-a6e2fe.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@acstll acstll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, this looks good to go!
There's only one lint error, and prettier missing 👀

@felix-ico
Copy link
Collaborator Author

felix-ico commented Oct 4, 2023

Hey, this looks good to go! There's only one lint error, and prettier missing 👀

@acstll I pushed a fix for the linter, but weirdly all the formatting errors were unrelated to the changes made here, so i opened a separate PR to take care of those..#2155, if you could have a quick look 🙏 not really sure how this happened though

nevermind all this, must have been a brainfart on my side, that PR is now showing 0 changed files

@felix-ico felix-ico merged commit 5d8d71f into main Oct 12, 2023
11 checks passed
@felix-ico felix-ico deleted the fix/checkbox-group-state branch October 12, 2023 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

State of checkbox group not consistent with its checkboxes
2 participants