refactor(segment): improves loading of the component and solves nested elemnts sizing issue #2358
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to address the issue raised here #2314:
As part of this PR the
segment-button
component is refactored to :Use better lifecycle hooks to reduce the component render
Use default values for the segment IDs
Fallback to
full-width
option in the segment when calculating the child button width, when nogetBoundingClientRect
orwidth
attribute exist for the segment child element. This issue will occur when thesegment-button
is rendered inside some other components<slot>
element as it will be rendered but withdisplay: none
attribute, which will cause the component to break.