Replacing app.kubernetes.io/name with kubernetes.io/metadata.name in mutatingwebhook
#2913
Assignees
Comments
HatchBV
changed the title
app.kubernetes.io/name with kubernetes.io/metadata.name app.kubernetes.io/name with kubernetes.io/metadata.name in mutatingwebhook
thallgren
added a commit
that referenced
this issue
Dec 8, 2022
The `kubernetes.io/metadata.name` is always set in Kubernetes versions 1.21 and higher. This commit ensures that it is used in favor of `app.kubernetes.io/name` on such versions. Closes #2913 Signed-off-by: Thomas Hallgren <thomas@datawire.io>
thallgren
added a commit
that referenced
this issue
Dec 9, 2022
The `kubernetes.io/metadata.name` is always set in Kubernetes versions 1.21 and higher. This commit ensures that it is used in favor of `app.kubernetes.io/name` on such versions. Closes #2913 Signed-off-by: Thomas Hallgren <thomas@datawire.io>
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Please describe your use case / problem.
Interception not working with namespace-scoped traffic manager installation with default labels of namespace even with k8s version > 1.21 because the mutating webhook use
app.kubernetes.io/namelabel for namespaces scoping which is not added by default to namespaces by k8s controllerDescribe the solution you'd like
I would recommend replacing
app.kubernetes.io/namewithkubernetes.io/metadata.namebecause according to the K8s documentationapp.kubernetes.io/nameis used for workload resources and namespace is not part of workload resources, andkubernetes.io/metadata.nameis set by the K8s API on all namespaces and can't be changed and can be used for targeting namespaceThe text was updated successfully, but these errors were encountered: