Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add process wide concurrency protection to Telepresence cache files. #3335

Closed
thallgren opened this issue Sep 4, 2023 · 0 comments · Fixed by #3336
Closed

Add process wide concurrency protection to Telepresence cache files. #3335

thallgren opened this issue Sep 4, 2023 · 0 comments · Fixed by #3336
Assignees

Comments

@thallgren
Copy link
Member

thallgren commented Sep 4, 2023

The Telepresence cache files are accessed by multiple processes without proper concurrency protection to prevent corruption. This is bad. It makes our CI-tests unstable, because they often do things in rapid succession that normal users wouldn't, but it may also cause problems in other scenarios as well, such as using concurrent containerized daemons, scripts, or intercept specs.

We must implement proper file locking. Pending this proposal to make the internal lockedfile Go package public, we can use the rogpeppe/go-internal/lockedfile.

@thallgren thallgren changed the title Add process wide concurrency protection to Telepresence config and cache files. Add process wide concurrency protection to Telepresence cache files. Sep 6, 2023
@thallgren thallgren linked a pull request Sep 6, 2023 that will close this issue
6 tasks
@thallgren thallgren self-assigned this Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant