Enforce file locks on cache files. #3336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces a new `lockedFS` to the `dos` package that uses the rogpeppe clone of the go internal `lockedfile` package to do advisory locking on the files. The Telepresence cache then uses this file system for all file accesses in the cache. Signed-off-by: Thomas Hallgren <thomas@datawire.io>
thallgren
added
the
ok to test
github-actions
bot
removed
the
ok to test
thallgren
requested review from
a team and
josecv
and removed request for
a team
josecv
approved these changes
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introduces a new
lockedFSto thedospackage that uses the rogpeppe clone of the go internallockedfilepackage to do advisory locking on the files. The Telepresence cache then uses this file system for all file accesses in the cache.Checklist
./CHANGELOG.yml.DEVELOPING.mdwith any special dev tricks I had to use to work on this code efficiently.TELEMETRY.mdif I added, changed, or removed a metric name.