Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(chart): specify port in hook urls #3161

Merged
merged 3 commits into from
May 15, 2023
Merged

fix(chart): specify port in hook urls #3161

merged 3 commits into from
May 15, 2023

Conversation

maxime1907
Copy link
Contributor

Description

Specify port in hook URLs when we want to use a different port with agentInjector.webhook.port

Checklist

  • I made sure to update ./CHANGELOG.md.
  • I made sure to add any docs changes required for my change (including release notes).
  • My change is adequately tested.
  • I updated DEVELOPING.md with any any special dev tricks I had to use to work on this code efficiently.
  • I updated TELEMETRY.md if I added, changed, or removed a metric name.
  • Once my PR is ready to have integration tests ran, I posted the PR in #telepresence-dev in the datawire-oss slack so that the "ok to test" label can be applied.

@maxime1907 maxime1907 force-pushed the fixport branch 2 times, most recently from ac77695 to 9bdadc4 Compare May 5, 2023 10:51
thallgren
thallgren requested changes May 5, 2023
View reviewed changes
Copy link
Member

@thallgren thallgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a .Values.agentInjector.webhook.port setting. Shouldn't that be used here instead of introducing a new value?

@maxime1907
fix(chart): specify port in hook urls
8f2c501 
Signed-off-by: Maxime Leroy <19607336+maxime1907@users.noreply.github.com>
@maxime1907
Copy link
Contributor Author

We have a .Values.agentInjector.webhook.port setting. Shouldn't that be used here instead of introducing a new value?

Ah yes my bad i meant to use this value, it should be good now!

@thallgren thallgren added the ok to test Applied by maintainers when a PR is ready to have tests run on it label May 15, 2023
@github-actions github-actions bot removed the ok to test Applied by maintainers when a PR is ready to have tests run on it label May 15, 2023
thallgren added 2 commits May 15, 2023 16:55
@thallgren
Merge branch 'release/v2' into fixport
b086bf9
@thallgren
Move changelog entry to 2.13.3
675b0e6 
Signed-off-by: Thomas Hallgren <thomas@datawire.io>
@thallgren thallgren merged commit 000636f into telepresenceio:release/v2 May 15, 2023
@thallgren
Copy link
Member

Thanks @maxime1907 for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thallgren thallgren thallgren approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maxime1907 @thallgren