Better discovery of local container-based clusters (kind or minikube). #3165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using `telepresence connect --docker` in combination with a kubeconfig that points to a cluster that runs in a container on the local host, that kubeconfig must be modified to instead point to a docker internal address:port, and the network that makes that address available must be added to the Telepresence daemon container. This commit improves the discovery of such configuration so that less assumpions are made regarding container names and port numbers. Instead, the discovery looks at some well-known labels and uses the docker configurations port bindings to figure out how a port on the host maps to a port in the container. Closes #3155 Signed-off-by: Thomas Hallgren <thomas@datawire.io>
thallgren
added
the
ok to test
github-actions
bot
removed
the
ok to test
knlambert
requested review from
a team and
josecv
and removed request for
a team and
njayp
josecv
approved these changes
May 8, 2023
Signed-off-by: Thomas Hallgren <thomas@datawire.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When using
telepresence connect --dockerin combination with a kubeconfig that points to a cluster that runs in a container on the local host, that kubeconfig must be modified to instead point to a docker internal address:port, and the network that makes that address available must be added to the Telepresence daemon container.This commit improves the discovery of such configuration so that less assumpions are made regarding container names and port numbers. Instead, the discovery looks at some well-known labels and uses the docker configurations port bindings to figure out how a port on the host maps to a port in the container.
Closes #3155
Checklist
./CHANGELOG.md.DEVELOPING.mdwith any any special dev tricks I had to use to work on this code efficiently.TELEMETRY.mdif I added, changed, or removed a metric name.