Correct namespace selector for cluster versions with non-numeric characters #3184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…acters. Now correctly handles versions like Major:'1', Minor:'22+'. Signed-off-by: Xu Zhang <xzhang@brex.com>
xzhang-brex
force-pushed
the
make-kube-version-more-flexible
branch
from
673b405 to
704745e
Compare
thallgren
added
the
ok to test
github-actions
bot
removed
the
ok to test
thallgren
approved these changes
May 16, 2023
|
Thank you so much for this contribution @xzhang-brex ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request addresses an issue with the mutating webhook where it previously could not correctly apply the namespace selector if the cluster version contained non-numeric characters.
The problem was primarily seen in cases where the Kubernetes version, specifically the minor version, included non-numeric characters, such as "22+".
Changes in this PR ensure that the webhook now correctly interprets and handles such versions. The namespace selector will now function as expected even when the cluster version is formatted like Major:"1", Minor:"22+".
Checklist
./CHANGELOG.md.DEVELOPING.mdwith any any special dev tricks I had to use to work on this code efficiently.TELEMETRY.mdif I added, changed, or removed a metric name.