WIP: add support for first-n-connections #3650
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
based64god
force-pushed
the
first-n-connections
branch
from
c5c7d05
to
7bc26e3
Compare
based64god
force-pushed
the
first-n-connections
branch
from
7bc26e3
to
983fe1a
Compare
|
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment, or this will be closed in 14 days. |
|
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment, or this will be closed in 14 days. |
|
This PR was closed because it has been stalled for 14 days with no activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Posting this to get some early feedback. Addressing checklist items in follow up commits.
The goal of this PR is to add support for the ability to proxy only the first N connections that get sent to a service, and then otherwise ignore subsequent connections. The intended use case here is to provide a helpful control mechanism for applications with exotic, long-lived application layer protocols for use during development:
to name a few.
Checklist
./CHANGELOG.yml.CONTRIBUTING.mdwith any special dev tricks I had to use to work on this code efficiently.TELEMETRY.mdif I added, changed, or removed a metric name.