Unify client configuration #3710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a regression where the actual traffic-agent got included in the telepresenceagents config-map. Signed-off-by: Thomas Hallgren <thomas@tada.se>
The `gopkg-in/yaml.v3` hasn't seen any activity for over two years, it has 287 issues and 218 PRs pending and Telepresence config contained a lot of code to work around its deficiencies. This commit replaces all uses of this package `sigs.k8s.io/yaml` and introduces `github.com/go-json-experiment/json` as the underlying framework to do all heavy lifting related to Marshal/Unmarshal. Signed-off-by: Thomas Hallgren <thomas@tada.se>
thallgren
force-pushed
the
thallgren/local-config
branch
4 times, most recently
from
6587ed0
to
85a423d
Compare
thallgren
added
the
ok to test
github-actions
bot
removed
the
ok to test
thallgren
force-pushed
the
thallgren/local-config
branch
from
85a423d
to
2df5e32
Compare
thallgren
added
the
ok to test
github-actions
bot
removed
the
ok to test
thallgren
added
the
ok to test
github-actions
bot
removed
the
ok to test
This is a fairly comprehensive change, but it's been pending for some time now, and gets rid of a lot of unnecessary conversion and utility functions. Signed-off-by: Thomas Hallgren <thomas@tada.se>
Signed-off-by: Thomas Hallgren <thomas@tada.se>
Signed-off-by: Thomas Hallgren <thomas@tada.se>
The `iputil.IPKey` was initially created to allow efficient use of an IP as a hash key. It's now redundant since we use `netip.Addr` everywhere. Signed-off-by: Thomas Hallgren <thomas@tada.se>
Signed-off-by: Thomas Hallgren <thomas@tada.se>
Signed-off-by: Thomas Hallgren <thomas@tada.se>
Telepresence will now use WebSockets instead of SPDY when creating port-forwards to the Kubernetes Cluster, and will fall back to SPDY when connecting to clusters that don't support SPDY. Use of the deprecated SPDY can be forced by setting `cluster.forceSPDY=true` in the `config.yml`. Signed-off-by: Thomas Hallgren <thomas@tada.se>
Signed-off-by: Thomas Hallgren <thomas@tada.se>
Signed-off-by: Thomas Hallgren <thomas@tada.se>
thallgren
force-pushed
the
thallgren/local-config
branch
from
592e60b
to
2f9fb32
Compare
thallgren
added
the
ok to test
github-actions
bot
removed
the
ok to test
Signed-off-by: Thomas Hallgren <thomas@tada.se>
thallgren
added
the
ok to test
github-actions
bot
removed
the
ok to test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, client configuration was divided between the config.yml file and a Kubernetes extension. DNS and
routing settings were initially found only in the extension. However, the Helm client structure allowed
entries from both.
To simplify this, we've now aligned the config.yml and Kubernetes extension with the Helm client structure.
This means DNS and routing settings are now included in both. The Kubernetes extension takes precedence over
the config.yml and Helm client object.
While the old-style Kubernetes extension is still supported for compatibility, it cannot be used with the new
style.
Closes #2675