Improve telepresence list performance #3712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This setting Controls the enablement of features more recent than the given version. In particular, it's intended to make newer grpc functions return an `Unimplemented` when set to a version where the function is not implemented. This setting is intended for test and debugging only. Signed-off-by: Thomas Hallgren <thomas@tada.se>
Signed-off-by: Thomas Hallgren <thomas@tada.se>
Signed-off-by: Thomas Hallgren <thomas@tada.se>
thallgren
added
the
ok to test
github-actions
bot
removed
the
ok to test
thallgren
force-pushed
the
thallgren/list-performance
branch
from
5de70fa
to
8ecd485
Compare
thallgren
added
the
ok to test
github-actions
bot
removed
the
ok to test
thallgren
force-pushed
the
thallgren/list-performance
branch
2 times, most recently
from
daa5d63
to
10c09f1
Compare
thallgren
added
the
ok to test
github-actions
bot
removed
the
ok to test
thallgren
added
the
ok to test
github-actions
bot
removed
the
ok to test
thallgren
force-pushed
the
thallgren/list-performance
branch
from
9f03665
to
66d188c
Compare
thallgren
added
the
ok to test
github-actions
bot
removed
the
ok to test
Let the `telepresence list` command use a workload collection that is backed by the traffic-managers `WatchWorkloads` function. The client will use local shared informers to watch the workloads when connecting to an older traffic-manager that doesn't support the `WatchWorkloads` call. Sort conditions by LastTransitionTime so that more recent has priority. When checking the state of an argo-rollout, it's essential to look at the transition timestamp, because the rollout can be both "progressing" and "available" when pausing between steps. We now look at the `RolloutAvailable` rather than `RolloutHealthy`. The latter is not set until all steps of a canary rollout have completed, which might be never. Signed-off-by: Thomas Hallgren <thomas@tada.se>
The condition "Rollout of n.n is not necessary. At least one pod has the desired agent state" must be reversed when deleting an agent so that we also have "Rollout of n.n is necessary. At least one pod still has an agent". Signed-off-by: Thomas Hallgren <thomas@tada.se>
Signed-off-by: Thomas Hallgren <thomas@tada.se>
thallgren
force-pushed
the
thallgren/list-performance
branch
from
66d188c
to
5596c91
Compare
thallgren
added
the
ok to test
github-actions
bot
removed
the
ok to test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the list command to optimize performance and reduce dependency on Kubernetes RBAC privileges. Instead of directly watching Kubernetes workload resources, the client now subscribes to the Traffic Manager's WorkloadEventsWatcher to track interceptable workloads. This change offers two key benefits:
Closes #3714