Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A few sentences describing the overall goals of the pull request's commits.
Currently there exists a deadlock in the following situation:
First, lets acknowledge that if isCI is set, we assume we dont have a release name/namespace. Therefore the chart skips the validation that release name is traffic-manager, which makes sense. The chart then defaults the traffic manager namespace to be ambassador. However this will throw if ambassador is not included in the list of namespaces.
Checklist
./CHANGELOG.yml
.CONTRIBUTING.md
with any special dev tricks I had to use to work on this code efficiently.