Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deployments, statefulSets, replicaSets to workloads Helm chart values #3718

Open
wants to merge 1 commit into
base: release/v2
Choose a base branch
from

Conversation

P0lip
Copy link
Contributor

@P0lip P0lip commented Nov 4, 2024

Description

This PR adds the remaining workload kinds Telepresence is able to intercept to the workloads option in Helm chart. This based on the initial suggestion made by @thallgren in
#3651 (comment).
To retain backwards compatibility all existing workload kinds that is Deployment, StatefulSet and ReplicaSet are enabled by default unless configured otherwise.

Checklist

  • I made sure to update ./CHANGELOG.yml.
  • I made sure to add any docs changes required for my change (including release notes).
  • My change is adequately tested.
  • I updated CONTRIBUTING.md with any special dev tricks I had to use to work on this code efficiently.
  • Once my PR is ready to have integration tests ran, I posted the PR in #telepresence-dev in the datawire-oss slack so that the "ok to test" label can be applied.

@P0lip P0lip self-assigned this Nov 4, 2024
@P0lip P0lip force-pushed the jrozek/extend-workloads-helm-chart-configuration branch from c7785a7 to e03bc20 Compare November 4, 2024 13:44
@P0lip P0lip added the ok to test Applied by maintainers when a PR is ready to have tests run on it label Nov 4, 2024
@github-actions github-actions bot removed the ok to test Applied by maintainers when a PR is ready to have tests run on it label Nov 4, 2024
@P0lip P0lip force-pushed the jrozek/extend-workloads-helm-chart-configuration branch from e03bc20 to 05f6452 Compare November 4, 2024 15:22
…alues

Signed-off-by: Jakub Rożek <jrozek@datawire.io>
@P0lip P0lip force-pushed the jrozek/extend-workloads-helm-chart-configuration branch from 05f6452 to af9d374 Compare November 4, 2024 15:46
@P0lip P0lip added the ok to test Applied by maintainers when a PR is ready to have tests run on it label Nov 4, 2024
@github-actions github-actions bot removed the ok to test Applied by maintainers when a PR is ready to have tests run on it label Nov 4, 2024
@P0lip P0lip marked this pull request as ready for review November 4, 2024 18:19
@P0lip P0lip requested a review from thallgren November 4, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant