This repository has been archived by the owner on Feb 2, 2021. It is now read-only.
Fix iOS11 Simulator log #1016
Merged
Fix iOS11 Simulator log #1016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KristianDD
force-pushed
the
kddimitrov/ios-11-logs
branch
from
094e3f6 to
acb47bc
Compare
|
@KristianDD - If you pass the |
mobile/ios/ios-log-filter.ts
Outdated
| @@ -8,7 +8,8 @@ export class IOSLogFilter implements Mobile.IPlatformLogFilter { | |||
|
|
|||
| if (specifiedLogLevel === this.$loggingLevels.info && data) { | |||
| if (pid) { | |||
| return data.indexOf(`[${pid}]`) !== -1 ? data.trim() : null; | |||
| const mathesPid = data.indexOf(`[${pid}]`) !== -1 || data.indexOf(` ${pid} `) !== -1; | |||
There was a problem hiding this comment.
mathesPid should be matchesPid maybe?
KristianDD
force-pushed
the
kddimitrov/ios-11-logs
branch
from
acb47bc to
b78fd25
Compare
KristianDD
force-pushed
the
kddimitrov/ios-11-logs
branch
from
a2f0b85 to
6a482f8
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the fix for NativeScript/nativescript-cli#3141 (comment).
Log format for iOS 10.3: "Oct 3 19:07:55 machinename cliapp[15339]: CONSOLE LOG file:///app/main-view-model.js:18:20: Test Console fix..."
Log format for iOS 11: "2017-10-09 13:34:38.527844+0300 localhost cliapp[22235]: (NativeScript) CONSOLE LOG file:///app/main-view-model.js:18:20: Test Console fix.."