Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Excluded URLs #153

Closed
jonchoi opened this issue Oct 4, 2019 · 7 comments · Fixed by #163
Closed

Excluded URLs #153

jonchoi opened this issue Oct 4, 2019 · 7 comments · Fixed by #163

Comments

@jonchoi
Copy link

jonchoi commented Oct 4, 2019

No settings access to excluded URLs? Is this a known issue?

Desktop (please complete the following information):

  • macOS version: 10.14.6 Mojave
  • Safari version: 13.0.1
  • Vimari version: Latest
@jonchoi jonchoi added the bug label Oct 4, 2019
@cloin
Copy link

cloin commented Oct 7, 2019

I'm not able to find the settings page for Vimari. So this might affect all customizable settings that are mentioned in readme.

@analyticd
Copy link

Same here on High Sierra and Safari 13.0.2

@cloin
Copy link

cloin commented Oct 10, 2019

Confirmed issue is also in binary distributed in the App Store. Light and dark mode.

  • macOS version: 10.14.6
  • Safari version: 13.0.1
  • Vimari version: 2.0.3

@danielcompton
Copy link
Member

This is a known issue, there is no settings page yet in the new version of Vimari. My main focus so far has been getting it on the App Store. Now that it's there I'm going to look more at features like this.

@cloin
Copy link

cloin commented Oct 29, 2019

@danielcompton understood. Respectfully, this application is quite ineffective without resolving this. If you aren't able to disable Vimari on certain pages, you're not able to use web app specific keyboard shortcuts. I'm looking forward to re-enabling this extension when this bug is resolved.

nieldm added a commit to nieldm/vimari that referenced this issue Dec 15, 2019
nieldm added a commit to nieldm/vimari that referenced this issue Dec 16, 2019
@namolnad
Copy link

@cloin @jonchoi FWIW, if you need to edit this prior to these improvements being merged in, looks like you can do so here: /Applications/Vimari.app/Contents/PlugIns/Vimari Extension.appex/Contents/Resources/settings.js. Just worked for me.

@namolnad
Copy link

I take this back, after a Safari restart it appears the extension will no longer load until the file is put back to its original state. Seems likely due to code signing

@nbelzer nbelzer mentioned this issue Jul 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants