Transparent Normal Mode #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 28, 2020
danielcompton
approved these changes
Aug 30, 2020
|
Just for anyone else following along, you can also disable Vimium's keybindings entirely by pressing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #188
This PR implements a new option
transparentBindings(better name suggestion welcome) that is by default set totrue. When enabled this makes the isolation between normal mode and insert mode more transparent as it allows all non-Vimari bound keys to be sent to the website (as if you were in insert mode). Keys bound to Vimari will however still be isolated from the website until the user enters insert mode.As the isolation happens on a per-key basis all keys, even if they are part of a multi-key binding and do not occur alone in any other binding, are included. This means that even though by default g doesn't do anything in Vimari it is isolated because it is part of both g+i,shift+g, and g+g.
This is aimed at improving the usability and compatibility for people upgrading to Vimari 2.1 as mentioned in #188. If people prefer the full isolation they can disable the option.