Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve sidecred logging #92

Merged
merged 5 commits into from
Dec 23, 2022
Merged

Improve sidecred logging #92

merged 5 commits into from
Dec 23, 2022

Conversation

mansn-at-telia
Copy link
Contributor

This PR adds the following,

  • A golang context object to calls, for future timeout handling, and carrying request data.
  • A logger to the context object, for easier logging in all the code.
  • A stats object to the context object, for easier collection of statistics.
  • A trace_id to the logs, for connecting the logs together in datadog.

@mansn-at-telia mansn-at-telia requested review from a team and itsdalmo as code owners December 22, 2022 14:03
myi6902
myi6902 approved these changes Dec 23, 2022
View reviewed changes
Copy link
Contributor

@myi6902 myi6902 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@myi6902 myi6902 merged commit 47f2cf1 into master Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@myi6902 myi6902 myi6902 approved these changes

@itsdalmo itsdalmo Awaiting requested review from itsdalmo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mansn-at-telia @myi6902