Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add number separators (commas) for block numbers #794

Closed
kylanhurt opened this issue Oct 23, 2023 · 2 comments
Closed

Add number separators (commas) for block numbers #794

kylanhurt opened this issue Oct 23, 2023 · 2 comments
Assignees

Comments

@kylanhurt
Copy link
Contributor

Describe the bug
Without number / thousands separators it becomes more difficult to read block numbers.

To Reproduce
Go to homepage

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
image

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.

@matthewdarwin
Copy link

Some languages use spaces, some use commas. The choice of 1000s separator character should depend on browser config, not hard-coded value.

@kylanhurt
Copy link
Contributor Author

@matthewdarwin Agreed. Current PR uses toLocaleString() which leaves it up to the browser.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants