Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comma separators for block numbers on homepage #796

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

kylanhurt
Copy link
Contributor

@kylanhurt kylanhurt commented Oct 23, 2023

Fixes #794

Description

Just added a couple of .toLocaleString() to the numbers

Test scenarios

Just go to homepage and check it yourself.

image

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have cleaned up the code in the areas my change touches
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings
  • I have removed any unnecessary console messages
  • I have included all english text to the translation file and/or created a new issue with the required translations for the currently supported languages
  • I have tested for mobile functionality and responsiveness
  • I have added appropriate test coverage

@netlify
Copy link

netlify bot commented Oct 23, 2023

Deploy Preview for obe-testnet ready!

Name Link
🔨 Latest commit 82392a1
🔍 Latest deploy log https://app.netlify.com/sites/obe-testnet/deploys/6536f21b3ae3cd000815b7b2
😎 Deploy Preview https://deploy-preview-796--obe-testnet.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Oct 23, 2023

Deploy Preview for obe-staging ready!

Name Link
🔨 Latest commit 82392a1
🔍 Latest deploy log https://app.netlify.com/sites/obe-staging/deploys/6536f21bef0afe0008ffff47
😎 Deploy Preview https://deploy-preview-796--obe-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@donnyquixotic donnyquixotic merged commit 74f2e04 into develop Oct 25, 2023
10 checks passed
@donnyquixotic donnyquixotic deleted the 794-thousands-separators branch October 25, 2023 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants