-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring multichain sidemenu to a selector component #692
Conversation
✅ Deploy Preview for obe-testnet ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for obe-staging ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Deploying with Cloudflare Pages
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we include changing the url according to the selected chain?
This would enable link sharing to the precise transaction/account in the specific chain
for example, for telos we should add ?network=telos
, based on the chain name we have on index.ts for each chain
I will do it in a different PR, opened #709 to keep track on this. This one will only change the side menu for the dropdown and update the ENV var name for it. Also, fixed some bugs on authentication regarding when change from one chain to another. |
7cbaba3
to
2665ba9
Compare
Fixes #706
Fixes #705
Description
Improving the UX of multi chain functionality by moving it from the side menu to a menu button and included a tag on the chain logo to indicate when the User is under a testnet environment.
Also, fixed a bug regarding authentication where the system was keeping the account connected when changing the network.
Test scenarios
Checklist: