Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme updates #698

Merged
merged 7 commits into from
Jun 15, 2023
Merged

Theme updates #698

merged 7 commits into from
Jun 15, 2023

Conversation

jaegerfe
Copy link
Collaborator

Description

Updating EOS and default themes; refactoring some components to improve the possiblity of customization.

  • Updating default theme to a dark grey mode;
  • Updating EOS theme to represent their branding;
  • Updating some components to improve the ability to customization;
  • Updating Vote cards to match with the designs on the other pages;

Telos theme:
image

New cards on Vote page:
image

EOS theme:
image

New default theme:
image

Test scenarios

Tested the colors with EOS and default theme;
Tested if the new changes were affecting Telos theme;

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have cleaned up the code in the areas my change touches
  • My changes generate no new warnings
  • I have checked my code and corrected any misspellings
  • I have removed any unnecessary console messages

@jaegerfe jaegerfe added the ✨ Enhancement Improvements on existing features label May 11, 2023
@jaegerfe jaegerfe self-assigned this May 11, 2023
@netlify
Copy link

netlify bot commented May 11, 2023

Deploy Preview for open-block-explorer ready!

Name Link
🔨 Latest commit ce92505
🔍 Latest deploy log https://app.netlify.com/sites/open-block-explorer/deploys/647600b7c1beca00080248eb
😎 Deploy Preview https://deploy-preview-698--open-block-explorer.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented May 11, 2023

Deploy Preview for obe-testnet ready!

Name Link
🔨 Latest commit 37b3dcd
🔍 Latest deploy log https://app.netlify.com/sites/obe-testnet/deploys/648b614c7d8ad80008af424a
😎 Deploy Preview https://deploy-preview-698--obe-testnet.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@jaegerfe jaegerfe marked this pull request as ready for review May 22, 2023 17:06
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented May 23, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 37b3dcd
Status: ✅  Deploy successful!
Preview URL: https://762a1a22.open-block-explorer.pages.dev
Branch Preview URL: https://theme-updates.open-block-explorer.pages.dev

View logs

@pongilo
Copy link
Collaborator

pongilo commented May 30, 2023

Should the jungle 4 follow the same EOS mainnet?

@jaegerfe
Copy link
Collaborator Author

Should the jungle 4 follow the same EOS mainnet?

Yes! Good catch! Already updated! Thank you!

@jaegerfe jaegerfe changed the base branch from master to develop May 30, 2023 13:58
Copy link
Contributor

@karynemayer karynemayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we also update the logos for the other chains and make sure they use the default theme?

@jaegerfe
Copy link
Collaborator Author

jaegerfe commented Jun 7, 2023

Could we also update the logos for the other chains and make sure they use the default theme?

The way that is implemented in this PR, any chain will use the default one and only apply their specific colors if they override them. The refactor that I'm working on for the routes that will change a little bit this mechanism.

About the logos, we can! Where could we get the new ones?

@netlify
Copy link

netlify bot commented Jun 13, 2023

Deploy Preview for obe-staging ready!

Name Link
🔨 Latest commit 37b3dcd
🔍 Latest deploy log https://app.netlify.com/sites/obe-staging/deploys/648b614cc38e7f000821e9d4
😎 Deploy Preview https://deploy-preview-698--obe-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@karynemayer karynemayer merged commit 58421e7 into develop Jun 15, 2023
@karynemayer karynemayer deleted the theme_updates branch June 15, 2023 19:16
@jaegerfe jaegerfe mentioned this pull request Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Enhancement Improvements on existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants