Fixes actions payload continuously appending #718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for obe-testnet ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for obe-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
donnyquixotic
suggested changes
Jun 26, 2023
donnyquixotic
suggested changes
Jun 26, 2023
donnyquixotic
suggested changes
Jun 26, 2023
Deploying with
|
| Latest commit: |
2b3398c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://19b0c060.open-block-explorer.pages.dev |
| Branch Preview URL: | https://updateauth-bug.open-block-explorer.pages.dev |
donnyquixotic
suggested changes
Jul 6, 2023
| let currentData = ref<string | unknown>(null); | ||
| const maxHeight = 57; // the maximum row height | ||
| const switchHeight = 20; | ||
| const maxHeightStyle = computed(() => |
There was a problem hiding this comment.
this doesn't need to be computed() since the values don't change or need to be reactive. optionally you could remove the switchHeight variable which isn't used elsewhere and just have const maxHeightStyle = 37px // comment whichever you prefer for readability.
Suggested change
| const maxHeightStyle = computed(() => | |
| const maxHeightStyle = `calc(${maxHeight}px - ${switchHeight}px)`; |
| <div class="text-weight-bold">memo: <span class="text-weight-regular" v-if="transferData.memo">{{transferData.memo}}</span><span class="text-weight-regular" v-else>n/a</span></div> | ||
| <div | ||
| class="relative-position" | ||
| :class="{'overflow-hidden': !showOverflow, 'div-compressed': !showOverflow}" |
There was a problem hiding this comment.
double-check this but I believe the quasar class overflow-hidden is redundant now due to div-compressed (doesn't appear to do anything when disabled in dev tools)
Suggested change
| :class="{'overflow-hidden': !showOverflow, 'div-compressed': !showOverflow}" | |
| :class="{ 'div-compressed': !showOverflow }" |
donnyquixotic
approved these changes
Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #697
Description
This PR fixes the issue where the content of an action is continuously appended to the table with the following changes:
Why? The request answer sometimes includes keys that are empty and sometimes it doesn't. The diff below illustrates the difference between the request payloads. Fun fact, they also change the order of the attributes, which is not depicted in the example below.
How? We recursively compare the each key since we can't predict the kind of data it will be. We ignore any key that has zero content in the comparison, so the objects are considered the same.
{ "data": { "permission": "active", "parent": "owner", "auth": { "threshold": 2, - + "keys": [], "accounts": [ { "permission": { "actor": "captaincrypt", "permission": "active" }, "weight": 1 }, ], - + "waits": [], }, "account": "tf" } },Why? Due to the complexity of the data that can come from the blockchain actions, a new component with the sole purpose of showing this data was created. It leverages recursion because of the lack of predictability on the JSON that comes from the endpoints and makes sure we show a simplified, indented version of the content.
Note that we don't print the information again if it was deemed equal to the previous one.
Test scenarios
Tested on the following transactions:
/transaction/9398eb3fd65179086d2cb571a82299fe16ac545a4724952f3d4dc8f1dd53fcac/transaction/cb0bc295eab73a01b931463e57f932774a59cddc804acab5e28112845ea4b2d1/transaction/e058a43cf19d2f736d60cddc046329b179d04fab5121eacce14db7f4db043341Note that thecontentkey issue will be addressed in another PR/issue/account/eosio.evmChecklist: